[Django] #28570: setting SRID in GEOSGeometry.clone() could be avoided for better performance on GEOS 3.3.1+

7 views
Skip to first unread message

Django

unread,
Sep 5, 2017, 12:36:36 PM9/5/17
to django-...@googlegroups.com
#28570: setting SRID in GEOSGeometry.clone() could be avoided for better
performance on GEOS 3.3.1+
------------------------------------------------+------------------------
Reporter: Sergey Fedoseev | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
GEOS sets SRID when geometry is cloned since version 3.3.1
(https://trac.osgeo.org/geos/ticket/464).
I think that we could set minimum required version to 3.3.1 because even
Debian oldoldstable has GEOS 3.3.3.

--
Ticket URL: <https://code.djangoproject.com/ticket/28570>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 5, 2017, 12:36:48 PM9/5/17
to django-...@googlegroups.com
#28570: setting SRID in GEOSGeometry.clone() could be avoided for better
performance on GEOS 3.3.1+
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sergey Fedoseev):

* status: new => assigned
* owner: nobody => Sergey Fedoseev


--
Ticket URL: <https://code.djangoproject.com/ticket/28570#comment:1>

Django

unread,
Sep 7, 2017, 9:17:30 AM9/7/17
to django-...@googlegroups.com
#28570: setting SRID in GEOSGeometry.clone() could be avoided for better
performance on GEOS 3.3.1+
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28570#comment:2>

Django

unread,
Sep 10, 2017, 2:59:53 PM9/10/17
to django-...@googlegroups.com
#28570: setting SRID in GEOSGeometry.clone() could be avoided for better
performance on GEOS 3.3.1+
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sergey Fedoseev):

[https://github.com/django/django/pull/9056 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28570#comment:3>

Django

unread,
Sep 11, 2017, 12:07:49 PM9/11/17
to django-...@googlegroups.com
#28570: setting SRID in GEOSGeometry.clone() could be avoided for better
performance on GEOS 3.3.1+
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1
* stage: Accepted => Ready for checkin


Comment:

I added documentation changes for dropping support for GEOS 3.3 to the
pull request. It's more than 5 years old which is our rough policy for
GEOS library support.

--
Ticket URL: <https://code.djangoproject.com/ticket/28570#comment:4>

Django

unread,
Sep 11, 2017, 1:57:38 PM9/11/17
to django-...@googlegroups.com
#28570: setting SRID in GEOSGeometry.clone() could be avoided for better
performance on GEOS 3.3.1+
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"bd903e8a6ec7a5b321f24096223e43e4aea5b653" bd903e8]:
{{{
#!CommitTicketReference repository=""
revision="bd903e8a6ec7a5b321f24096223e43e4aea5b653"
Fixed #28570 -- Dropped support for GEOS 3.3.x.

Removed setting SRID in GEOSGeometry.clone() which was only required
in GEOS 3.3.0.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28570#comment:5>

Reply all
Reply to author
Forward
0 new messages