[Django] #20676: Trac gave Core dev status to Anon user

[Django]

#20676: Trac gave Core dev status to Anon user
-------------------------------------+--------------------
Reporter: alexcouper | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+--------------------
I assigned a ticket to myself anonymously and was given Core status:

https://code.djangoproject.com/ticket/20649#comment:4

I've now reassigned it to a registered version of me and all is well.

--
Ticket URL: <https://code.djangoproject.com/ticket/20676>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#20676: Wrong users highlighted as core devs in trac
-------------------------------------+-------------------------------------
Reporter: alexcouper | Owner: bmispelon
Type: Bug | Status: assigned
Component: *.djangoproject.com | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by bmispelon):

* status: new => assigned
* cc: bmispelon@… (added)
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => bmispelon
* needs_docs: => 0
* stage: Unreviewed => Accepted

Comment:

The highlighting of core developers is done client-side with javascript.

As it turns out, the regular expression used to detect usernames stops at
whitespace so your username ends up being `Alex`, a username belonging to
Alex Gaynor who is indeed a core developer.

I'll look into this and see if the regex can be fixed or if we need to
change something in trac.

Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/20676#comment:1>

[Django]

#20676: Wrong users highlighted as core devs in trac
-------------------------------------+-------------------------------------
Reporter: alexcouper | Owner: bmispelon
Type: Bug | Status: assigned

Component: *.djangoproject.com | Version: 1.5

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------

Comment (by aaugustin):

Computer.

:D

--
Ticket URL: <https://code.djangoproject.com/ticket/20676#comment:2>

[Django]

#20676: Wrong users highlighted as core devs in trac
-------------------------------------+-------------------------------------
Reporter: alexcouper | Owner: bmispelon
Type: Bug | Status: assigned

Component: *.djangoproject.com | Version: 1.5

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by bmispelon):

* has_patch: 0 => 1

Comment:

After digging a bit deeper into this issue, I'm starting to think the only
sane fix would be to make everone named Alex a core developer...

The problem we have is that trac sometimes likes to use the full name of a
user instead of his/her username when displaying a comment.
This means that we can't check reliably whether a user is a core dev or
not.

I "improved" the username-extracting code to reject everything containing
an "@" character.
This won't fix the core issue, but it should at least get rid of the false
positives.

I hope you enjoyed your "core dev" highlight while it lasted ;)

https://github.com/django/code.djangoproject.com/pull/7

--
Ticket URL: <https://code.djangoproject.com/ticket/20676#comment:3>

[Django]

#20676: Wrong users highlighted as core devs in trac
-------------------------------------+-------------------------------------
Reporter: alexcouper | Owner: bmispelon
Type: Bug | Status: assigned

Component: *.djangoproject.com | Version: 1.5

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------

Comment (by aaugustin):

I applied the patch and I confirmed it fixes the issue.

--
Ticket URL: <https://code.djangoproject.com/ticket/20676#comment:4>

[Django]

#20676: Wrong users highlighted as core devs in trac
-------------------------------------+-------------------------------------
Reporter: alexcouper | Owner: bmispelon

Type: Bug | Status: closed
Component: *.djangoproject.com | Version: 1.5
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by aaugustin):

* status: assigned => closed
* resolution: => fixed

--
Ticket URL: <https://code.djangoproject.com/ticket/20676#comment:5>