[Django] #30066: UserManager.create_superuser doesn't allow for omitting email or password, unlike create_user which does.
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Reporter: Joshua | Owner: nobody
Cannon |
Type: Bug | Status: new
Component: | Version: 2.1
contrib.auth |
Severity: Normal | Keywords: create_superuser
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
I couldn't find any historical information on whether or not this is
intentional, but `create_user`/`create_superuser` seem to mirror each
other except that `create_superuser` doesn't allow the caller to omit
`email` and `password` parameters.
[https://github.com/django/django/commit/fd2b99b5f122911b895987329507ee419a159a2c
This commit] introduced omitting `password`, and
[https://github.com/django/django/commit/f54135fa4dc9fd45d86ea2944191d58e00725779
this commit] introduced omitting `email`, but neither touches
`create_superuser`.
--
Ticket URL: <https://code.djangoproject.com/ticket/30066>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
| Bera
Type: Bug | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Abhishek Bera
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:1>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
| Bera
Type: Bug | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Abhishek Bera):
I added a test case with no email and password for the super user which
failed. later i changed the code in the models to email = None and
password = None in the contrib/auth/models createsuperuser params.
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:2>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Bera
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:3>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Bera
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
[https://docs.djangoproject.com/en/dev/topics/auth/customizing/#django.contrib.auth.models.CustomUserManager.create_superuser
The documentation] says, The prototype of `create_superuser()` should
accept the username field, plus all required fields as arguments." and
"Unlike `create_user()`, `create_superuser()` must require the caller to
provide a password."
For the default user mode, `User.REQUIRED_FIELDS = ['email']` so that
explains the original implementation. The documentation for
`CustomUserManager.create_user()` wasn't updated after
f54135fa4dc9fd45d86ea2944191d58e00725779. It still says, "The prototype of
`create_user()` should accept the username field, plus all required fields
as arguments." which is violated for the default case.
I don't have a strong opinion about how to proceed but if we proceed with
the changes, some documentation changes are required.
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:4>
Django
unlike create_user which does.
Reporter: Joshua Cannon | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by Abhishek Bera):
* owner: Abhishek Bera => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:5>
Django
unlike create_user which does.
Reporter: Joshua Cannon | Owner: xurror
Type: Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by xurror):
* owner: (none) => xurror
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:6>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Rios
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: (none) => Daniel Rios
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:6>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Rios
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:7>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Rios
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
Just a couple of minor comments on the PR. Marking "Patch needs
improvement", please uncheck that when those are addressed.
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:8>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Rios
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 2.1
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:9>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Rios
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: create_superuser | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* version: 2.1 => master
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:10>
Django
unlike create_user which does.
-------------------------------------+-------------------------------------
Type: | Rios
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: create_superuser | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"b5a5c92c72cc179b5a9a888039cdd2f0680bff36" b5a5c92c]:
{{{
#!CommitTicketReference repository=""
revision="b5a5c92c72cc179b5a9a888039cdd2f0680bff36"
Fixed #30066 -- Enabled super user creation without email and password
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30066#comment:11>