[Django] #28216: Add next_page to LoginView
Django
----------------------------------------+--------------------------------
Reporter: ThinkChaos | Owner: nobody
Type: New feature | Status: new
Component: contrib.auth | Version: 1.11
Severity: Normal | Keywords: auth,LoginView
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+--------------------------------
`LogoutView` has a `next_page` attribute used to override
`settings.LOGOUT_REDIRECT_URL`.
It would be nice if `LoginView` had the same mechanism.
--
Ticket URL: <https://code.djangoproject.com/ticket/28216>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: ThinkChaos | Owner: nobody
Type: New feature | Status: new
Component: contrib.auth | Version: 1.11
Keywords: auth,LoginView | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham):
Did you consider overriding the `get_success_url()` method? Perhaps that
method could be documented.
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:1>
Django
Reporter: ThinkChaos | Owner: nobody
Type: New feature | Status: new
Component: contrib.auth | Version: 1.11
Keywords: auth,LoginView | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by ThinkChaos):
Yes I have, the issue with that is when `redirect_authenticated_user =
True`, `dispatch` also has redirect logic.
No I don't. It's mostly for symmetry with `LogoutView` so that I have
redirects in the same view file, and not in the settings.
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:2>
Django
Reporter: ThinkChaos | Owner: nobody
Type: New feature | Status: new
Component: contrib.auth | Version: 1.11
Keywords: auth,LoginView | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
Comment:
I guess we could see what a patch looks like.
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:3>
Django
Reporter: ThinkChaos | Owner: ThinkChaos
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution:
Keywords: auth,LoginView | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by ThinkChaos):
* status: new => assigned
* owner: nobody => ThinkChaos
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:4>
Django
Reporter: ThinkChaos | Owner: ThinkChaos
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: auth,LoginView | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by ThinkChaos):
[https://github.com/django/django/pull/8630 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:5>
Django
Reporter: ThinkChaos | Owner: ThinkChaos
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: auth,LoginView | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by Mads Jensen):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:6>
Django
Reporter: ThinkChaos | Owner: ThinkChaos
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: auth,LoginView | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by ThinkChaos):
* needs_tests: 1 => 0
Comment:
I just pushed tests.
Sorry it took so long, I didn't find the tests for LogoutView when I first
checked.
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:7>
Django
Reporter: ThinkChaos | Owner: ThinkChaos
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: auth,LoginView | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:8>
Django
Reporter: ThinkChaos | Owner: ThinkChaos
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: auth,LoginView | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:9>
Django
Reporter: ThinkChaos | Owner:
| ThinkChaos
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: auth,LoginView | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:10>
Django
Reporter: ThinkChaos | Owner:
| ThinkChaos
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: auth,LoginView | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"b99d6c9cbc8eecf480892599201eef0d14b20d71" b99d6c9c]:
{{{
#!CommitTicketReference repository=""
revision="b99d6c9cbc8eecf480892599201eef0d14b20d71"
Fixed #28216 -- Added next_page/get_default_redirect_url() to LoginView.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28216#comment:11>