[Django] #32313: Queryset in_bulk docs don't explicit field_name as kwarg only

2 views
Skip to first unread message

Django

unread,
Jan 4, 2021, 9:21:51 AM1/4/21
to django-...@googlegroups.com
#32313: Queryset in_bulk docs don't explicit field_name as kwarg only
------------------------------------------------+------------------------
Reporter: Iuri de Silvio | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I had to check the code to validate the `in_bulk` signature with kwarg
only `*, field_name=None`. I think it is a documentation bug.

--
Ticket URL: <https://code.djangoproject.com/ticket/32313>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 4, 2021, 9:23:45 AM1/4/21
to django-...@googlegroups.com
#32313: Queryset in_bulk docs don't explicit field_name as kwarg only
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Iuri de Silvio):

* owner: nobody => Iuri de Silvio
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/32313#comment:1>

Django

unread,
Jan 4, 2021, 10:43:18 AM1/4/21
to django-...@googlegroups.com
#32313: Queryset in_bulk docs don't explicit field_name as kwarg only
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


Comment:

Seems reasonable. Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/32313#comment:2>

Django

unread,
Jan 4, 2021, 10:43:31 AM1/4/21
to django-...@googlegroups.com
#32313: Queryset in_bulk docs don't explicit field_name as kwarg only
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32313#comment:3>

Django

unread,
Jan 11, 2021, 2:01:07 AM1/11/21
to django-...@googlegroups.com
#32313: Queryset in_bulk docs don't explicit field_name as kwarg only
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"02391bc98c406f3cd5e329d252ec5c4b63cf979e" 02391bc]:
{{{
#!CommitTicketReference repository=""
revision="02391bc98c406f3cd5e329d252ec5c4b63cf979e"
Fixed #32313 -- Corrected QuerySet.in_bulk() signature.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32313#comment:4>

Django

unread,
Jan 11, 2021, 2:02:40 AM1/11/21
to django-...@googlegroups.com
#32313: Queryset in_bulk docs don't explicit field_name as kwarg only
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: closed
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"1dd159f16ed0240c7fe50e25510f54d035d1f7ee" 1dd159f]:
{{{
#!CommitTicketReference repository=""
revision="1dd159f16ed0240c7fe50e25510f54d035d1f7ee"
[3.1.x] Fixed #32313 -- Corrected QuerySet.in_bulk() signature.

Backport of 02391bc98c406f3cd5e329d252ec5c4b63cf979e from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32313#comment:5>

Reply all
Reply to author
Forward
0 new messages