[Django] #25631: AsGeoJSON, AsGML, AsKML are listed as supported by SpatiaLite without taking into account used version
Django
taking into account used version
----------------------------+--------------------
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
----------------------------+--------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/25631>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sir-sigurd):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
PR -- https://github.com/django/django/pull/5502
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:1>
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by timgraham):
* version: master => 1.9b1
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:2>
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by claudep):
I'm not sure whether we should simply remove `_version_greater_2_4_0_rc4`.
A system with such old version of Spatialite is probably also using an
unsupported version of Python (Debian squeeze is such a case for example).
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:3>
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by timgraham):
Sounds good to me, Claude. I didn't lookup how old that check was.
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:4>
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by sir-sigurd):
SpatiaLite was released on 2010-01-10 and Python 2.7 was released on
2010-01-10, so I think this version mix could used in theory, however I
don't think anyone will use such old software and new Django version
together.
I think it would be more correct to apply the current patch to Django 1.9
and fully drop support to SpatiaLite 2.4 in the next release.
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:5>
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.9b1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"6fb9424ff034b45cee3f16eafda3e4629545ce4f" 6fb9424f]:
{{{
#!CommitTicketReference repository=""
revision="6fb9424ff034b45cee3f16eafda3e4629545ce4f"
[1.9.x] Fixed #25631 -- Fixed support detection for some DB functions in
SpatiaLite backend.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:6>
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.9b1
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Sure, I merged that commit to 1.9.x. Could you update the PR for master?
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:7>
Django
taking into account used version
Reporter: sir-sigurd | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.9b1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
Note that we are not dropping support for SpatiaLite 2.4, just for pre-RC4
versions.
--
Ticket URL: <https://code.djangoproject.com/ticket/25631#comment:8>