[Django] #27640: HTTPResponse.__repr__ errors when Content-Type header is not defined

[Django]

#27640: HTTPResponse.__repr__ errors when Content-Type header is not defined
-----------------------------------------+------------------------
Reporter: Adam Chainz | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
As reported [https://groups.google.com/forum/#!msg/django-
developers/Dd-R-7YiQYQ/kM9PoQxiEQAJ on the mailing list],
HTTPResponse.__repr__ crashes when the Content-Type header is not defined.
It's legitimate that it's not defined when there is no body, e.g. for HTTP
204 responses ([https://stackoverflow.com/questions/21029351/what-content-
type-should-a-204-no-response-use StackOverflow]).

--
Ticket URL: <https://code.djangoproject.com/ticket/27640>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#27640: HTTPResponse.__repr__ errors when Content-Type header is not defined

-------------------------------+------------------------------------

Reporter: Adam Chainz | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.10

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted

Old description:

> As reported [https://groups.google.com/forum/#!msg/django-
> developers/Dd-R-7YiQYQ/kM9PoQxiEQAJ on the mailing list],
> HTTPResponse.__repr__ crashes when the Content-Type header is not
> defined. It's legitimate that it's not defined when there is no body,
> e.g. for HTTP 204 responses
> ([https://stackoverflow.com/questions/21029351/what-content-type-
> should-a-204-no-response-use StackOverflow]).

New description:

As reported [https://groups.google.com/forum/#!msg/django-
developers/Dd-R-7YiQYQ/kM9PoQxiEQAJ on the mailing list],
`HTTPResponse.__repr__` crashes when the Content-Type header is not
defined. It's legitimate that it's not defined when there is no body, e.g.

for HTTP 204 responses ([https://stackoverflow.com/questions/21029351
/what-content-type-should-a-204-no-response-use StackOverflow]).

--

--
Ticket URL: <https://code.djangoproject.com/ticket/27640#comment:1>

[Django]

#27640: HTTPResponse.__repr__ errors when Content-Type header is not defined

-------------------------------+-------------------------------------
Reporter: Adam Chainz | Owner: roboslone
Type: Bug | Status: assigned

Component: HTTP handling | Version: 1.10

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+-------------------------------------
Changes (by roboslone):

* owner: nobody => roboslone
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/27640#comment:2>

[Django]

#27640: HTTPResponse.__repr__ errors when Content-Type header is not defined

-------------------------------+-------------------------------------
Reporter: Adam Chainz | Owner: roboslone
Type: Bug | Status: assigned

Component: HTTP handling | Version: 1.10

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+-------------------------------------
Changes (by roboslone):

* has_patch: 0 => 1

Old description:

> As reported [https://groups.google.com/forum/#!msg/django-
> developers/Dd-R-7YiQYQ/kM9PoQxiEQAJ on the mailing list],
> `HTTPResponse.__repr__` crashes when the Content-Type header is not
> defined. It's legitimate that it's not defined when there is no body,
> e.g. for HTTP 204 responses

> ([https://stackoverflow.com/questions/21029351/what-content-type-
> should-a-204-no-response-use StackOverflow]).

New description:

As reported [https://groups.google.com/forum/#!msg/django-

developers/Dd-R-7YiQYQ/kM9PoQxiEQAJ on the mailing list],
`HTTPResponse.__repr__` crashes when the Content-Type header is not
defined. It's legitimate that it's not defined when there is no body, e.g.
for HTTP 204 responses ([https://stackoverflow.com/questions/21029351
/what-content-type-should-a-204-no-response-use StackOverflow]).

[https://github.com/django/django/pull/7746 PR]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/27640#comment:3>

[Django]

#27640: HTTPResponse.__repr__ errors when Content-Type header is not defined

-------------------------------------+-------------------------------------

Reporter: Adam Chainz | Owner: roboslone
Type: Bug | Status: assigned

Component: HTTP handling | Version: 1.10

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/27640#comment:4>

[Django]

#27640: HTTPResponse.__repr__ errors when Content-Type header is not defined

-------------------------------------+-------------------------------------
Reporter: Adam Chainz | Owner: roboslone

Type: Bug | Status: closed

Component: HTTP handling | Version: 1.10

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"544b2ef29f0f2577912f88cf746ae0ca5877b5f8" 544b2ef2]:
{{{
#!CommitTicketReference repository=""
revision="544b2ef29f0f2577912f88cf746ae0ca5877b5f8"
Fixed #27640 -- Fixed HttpResponse's __repr__() without a 'Content-Type'
header.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27640#comment:5>