[Django] #25378: Admin flat theme needs :focus styling on buttons for tab through

35 views
Skip to first unread message

Django

unread,
Sep 10, 2015, 5:27:59 PM9/10/15
to django-...@googlegroups.com
#25378: Admin flat theme needs :focus styling on buttons for tab through
-------------------------------+------------------------
Reporter: ryangallen | Owner: ryangallen
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------
When tabbing through the admin with the new flat theme, buttons do not
visually indicate they are the current tabbed item.

--
Ticket URL: <https://code.djangoproject.com/ticket/25378>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 10, 2015, 7:29:41 PM9/10/15
to django-...@googlegroups.com
#25378: Admin flat theme needs :focus styling on buttons for tab through
-------------------------------------+-------------------------------------
Reporter: ryangallen | Owner:
Type: | ryangallen
Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: 1.9 | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by timgraham):

* cc: elky (added)
* needs_better_patch: => 0
* needs_tests: => 0
* easy: 1 => 0
* keywords: => 1.9
* needs_docs: => 0
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/25378#comment:1>

Django

unread,
Sep 11, 2015, 5:26:31 PM9/11/15
to django-...@googlegroups.com
#25378: Admin flat theme needs :focus styling on buttons for tab through
-------------------------------------+-------------------------------------
Reporter: ryangallen | Owner:
Type: | ryangallen
Cleanup/optimization | Status: new
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: 1.9 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by ryangallen):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25378#comment:2>

Django

unread,
Sep 11, 2015, 5:26:43 PM9/11/15
to django-...@googlegroups.com
#25378: Admin flat theme needs :focus styling on buttons for tab through
-------------------------------------+-------------------------------------
Reporter: ryangallen | Owner:
Type: | ryangallen
Cleanup/optimization | Status: new
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: 1.9 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by ryangallen):

https://github.com/django/django/pull/5272

--
Ticket URL: <https://code.djangoproject.com/ticket/25378#comment:3>

Django

unread,
Sep 12, 2015, 11:53:56 AM9/12/15
to django-...@googlegroups.com
#25378: Admin flat theme needs :focus styling on buttons for tab through
-------------------------------------+-------------------------------------
Reporter: ryangallen | Owner:
Type: | ryangallen
Cleanup/optimization | Status: new
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: 1.9 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by ryangallen):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25378#comment:4>

Django

unread,
Sep 16, 2015, 7:27:05 PM9/16/15
to django-...@googlegroups.com
#25378: Admin flat theme needs :focus styling on buttons for tab through
-------------------------------------+-------------------------------------
Reporter: ryangallen | Owner:
Type: | ryangallen
Cleanup/optimization | Status: new
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: 1.9 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0


Comment:

elky will review the patch.

--
Ticket URL: <https://code.djangoproject.com/ticket/25378#comment:5>

Django

unread,
Sep 23, 2015, 5:52:45 PM9/23/15
to django-...@googlegroups.com
#25378: Admin flat theme needs :focus styling on buttons for tab through
-------------------------------------+-------------------------------------
Reporter: ryangallen | Owner:
Type: | ryangallen
Cleanup/optimization | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: 1.9 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"25cccca0a286585b9896546d57559e41b4e2ca16" 25cccca0]:
{{{
#!CommitTicketReference repository=""
revision="25cccca0a286585b9896546d57559e41b4e2ca16"
Fixed #25378 -- Improved tab through experience in admin.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25378#comment:6>

Reply all
Reply to author
Forward
0 new messages