[Django] #32072: Search bar input in admin page is out of proportion in Django 3.1.2

14 views
Skip to first unread message

Django

unread,
Oct 4, 2020, 10:27:30 PM10/4/20
to django-...@googlegroups.com
#32072: Search bar input in admin page is out of proportion in Django 3.1.2
-----------------------------------------+------------------------
Reporter: realsuayip | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-----------------------------------------+------------------------
In Django 3.1.2, admin search bar has extra height (most probably because
of the unintended/indirect padding rule added in 3.1.2)

Images respectively taken in 3.1.1 and 3.1.2

[[Image(https://i.imgur.com/oEeH3yO.png)]]
[[Image(https://i.imgur.com/SnqLv2H.png)]]

Related pull w/ diff:
https://github.com/django/django/commit/8ee4bb6ffcb3346c0fa8fb194986fbf9edadc822
#diff-73825862a22f60a0cb787fdc5ddec316L79

--
Ticket URL: <https://code.djangoproject.com/ticket/32072>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 5, 2020, 12:40:09 AM10/5/20
to django-...@googlegroups.com
#32072: Search bar input in admin page is out of proportion in Django 3.1.2
--------------------------------+------------------------------------
Reporter: şuayip üzülmez | Owner: nobody

Type: Bug | Status: new
Component: contrib.admin | Version: 3.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------+------------------------------------
Changes (by felixxm):

* cc: Tom Carrick (added)
* stage: Unreviewed => Accepted


Comment:

Agreed, it's a small visual regression in
8ee4bb6ffcb3346c0fa8fb194986fbf9edadc822.

--
Ticket URL: <https://code.djangoproject.com/ticket/32072#comment:1>

Django

unread,
Oct 5, 2020, 4:13:52 AM10/5/20
to django-...@googlegroups.com
#32072: Search bar input in admin page is out of proportion in Django 3.1.2
--------------------------------+---------------------------------------
Reporter: şuayip üzülmez | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------+---------------------------------------
Changes (by Tom Carrick):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/13491 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32072#comment:3>

Django

unread,
Oct 5, 2020, 8:08:23 AM10/5/20
to django-...@googlegroups.com
#32072: Search bar input in admin page is out of proportion in Django 3.1.2
-------------------------------------+-------------------------------------

Reporter: şuayip üzülmez | Owner: Tom
| Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by felixxm):

* severity: Normal => Release blocker
* stage: Accepted => Ready for checkin


Comment:

We should backport the fix because it basically restores the previous
behavior.

--
Ticket URL: <https://code.djangoproject.com/ticket/32072#comment:4>

Django

unread,
Oct 6, 2020, 5:58:06 AM10/6/20
to django-...@googlegroups.com
#32072: Search bar input in admin page is out of proportion in Django 3.1.2
-------------------------------------+-------------------------------------
Reporter: şuayip üzülmez | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.1
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"3add635ff7b5dd3eb35d58f1120488d448fa286f" 3add635f]:
{{{
#!CommitTicketReference repository=""
revision="3add635ff7b5dd3eb35d58f1120488d448fa286f"
[3.1.x] Fixed #32072 -- Fixed admin search bar height.

Thanks şuayip üzülmez for the report.

Regression in 8ee4bb6ffcb3346c0fa8fb194986fbf9edadc822.

Backport of 342a41740dcfe48a5cd4560c63eeca4d7d41610d from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32072#comment:6>

Reply all
Reply to author
Forward
0 new messages