Re: [Django] #6870: pre_delete should be sent before collecting ForeignKey relationships

8 views
Skip to first unread message

Django

unread,
Sep 8, 2011, 2:26:31 PM9/8/11
to django-...@googlegroups.com
#6870: pre_delete should be sent before collecting ForeignKey relationships
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
wkornewald | Status: new
Type: Bug | Component: Database layer
Milestone: | (models, ORM)
Version: SVN | Severity: Normal
Resolution: | Keywords: pre_delete signals
Triage Stage: Accepted | related
Needs documentation: 1 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 0
UI/UX: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by jrothenbuhler):

* cc: jakerothenbuhler@… (added)
* ui_ux: => 0
* easy: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/6870#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 8, 2011, 2:29:15 PM9/8/11
to django-...@googlegroups.com
#6870: pre_delete should be sent before collecting ForeignKey relationships
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
wkornewald | Status: new
Type: Bug | Component: Database layer
Milestone: | (models, ORM)
Version: SVN | Severity: Normal
Resolution: | Keywords: pre_delete signals
Triage Stage: Accepted | related
Needs documentation: 1 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 0
UI/UX: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by jashugan):

* cc: jashugan (added)


Comment:

The original use-case still exists for generic relations, which does not
support the on_delete functionality given by #7593.

--
Ticket URL: <https://code.djangoproject.com/ticket/6870#comment:13>

Django

unread,
Dec 20, 2011, 7:18:49 AM12/20/11
to django-...@googlegroups.com
#6870: pre_delete should be sent before collecting ForeignKey relationships
-------------------------------------+-------------------------------------
Reporter: wkornewald | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: SVN
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: pre_delete signals | Needs documentation: 1
related | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by ambv):

There are more use-cases than that. One of those is Admin's object
deletion. Let me give you an example:

I have a `Team` model and a `Member` model. `Team`s have `Member`s.
Trivial stuff. I also log every change on a `Team` or its `Member`s by
creating `LogEntry` objects. So, when a `Member` is deleted, I have a
`pre_delete` signal that saves the `LogEntry` ("member parted") for the
related `Team`. Now, when I try to delete a `Team` from the Admin, during
deletion of existing `Member`s, log entries are created by the
`pre_delete` signal and the transaction fails.

Currently as a workaround you have to either let orphaned objects litter
the DB by using `on_delete` or to create another `pre_delete` signal for
the `Team` model which does `instance.logentry_set.all().delete()`.

--
Ticket URL: <https://code.djangoproject.com/ticket/6870#comment:14>

Django

unread,
Mar 21, 2013, 5:41:43 AM3/21/13
to django-...@googlegroups.com
#6870: pre_delete should be sent before collecting ForeignKey relationships
-------------------------------------+-------------------------------------
Reporter: wkornewald | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master

(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: pre_delete signals | Needs documentation: 1
related | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by anonymous):

I've run in the same problem, not easy to debug. I'd be great to see it
fixed someday.

--
Ticket URL: <https://code.djangoproject.com/ticket/6870#comment:15>

Django

unread,
Nov 29, 2018, 1:53:57 PM11/29/18
to django-...@googlegroups.com
#6870: pre_delete should be sent before collecting ForeignKey relationships
-------------------------------------+-------------------------------------
Reporter: Waldemar Kornewald | Owner: nobody

Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: pre_delete signals | Triage Stage: Accepted
related |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tiedye):

Will this be addressed at any point? I've been running into this issue
for the past month.

--
Ticket URL: <https://code.djangoproject.com/ticket/6870#comment:16>

Django

unread,
Mar 12, 2024, 10:03:28 AMMar 12
to django-...@googlegroups.com
#6870: pre_delete should be sent before collecting ForeignKey relationships
-------------------------------------+-------------------------------------
Reporter: Waldemar Kornewald | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: pre_delete signals | Triage Stage: Accepted
related |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ülgen Sarıkavak):

* cc: Ülgen Sarıkavak (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/6870#comment:17>
Reply all
Reply to author
Forward
0 new messages