Re: [Django] #13721: pass extra content-type values to file upload handlers
Django
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
wkornewald | Status: new
Type: New | Component: File
feature | uploads/storage
Milestone: 1.3 | Severity: Normal
Version: 1.2 | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 1 |
-------------------------------------+-------------------------------------
Changes (by patchhammer):
* needs_better_patch: 0 => 1
* easy: => 0
Comment:
content_type_extra.diff fails to apply cleanly on to trunk
--
Ticket URL: <http://code.djangoproject.com/ticket/13721#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
wkornewald | Status: new
Type: New | Component: File
feature | uploads/storage
Version: SVN | Keywords:
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by wkornewald):
* needs_better_patch: 1 => 0
* version: 1.2 => SVN
* milestone: 1.3 => 1.4
Comment:
I've updated the patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:12>
Django
Reporter: wkornewald | Owner: nobody
Type: New feature | Status: new
Component: File uploads/storage | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by wkornewald):
* cc: wkornewald@… (removed)
* ui_ux: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:14>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by grant.callaghan@…):
+1. I would really like to see this patch applied
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:15>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: nobody
Type: New feature | Status: new
Component: File uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by anonymous):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:16>
Django
--------------------------------------+------------------------------------
Type: New feature | Status: assigned
Component: File uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* owner: nobody => mvschaik
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:17>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: mvschaik
Type: New feature | Status: assigned
Component: File uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* needs_better_patch: 0 => 1
Comment:
line 34 and 35 of the patch are made redundant by the previous line:
{{{
content_type_extra = meta_data.get('content-type', (0, {}))[1]
}}}
`content_type_extra` is then guaranteed not to be `None`.
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:18>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: mvschaik
Type: New feature | Status: assigned
Component: File uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by kagia):
@mvschaik are you still working on this? You may want to take a look at
this [https://github.com/kagia/django/compare/ticket_13721 my branch]
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:19>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: mvschaik
Type: New feature | Status: assigned
Component: File uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* cc: timograham@… (added)
* needs_better_patch: 1 => 0
Comment:
Edited version of kagia's branch:
https://github.com/django/django/pull/1301
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:20>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: mvschaik
Component: File uploads/storage | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"b0953dc91385fb2823294a76d3c99e01c7b7e4ee"]:
{{{
#!CommitTicketReference repository=""
revision="b0953dc91385fb2823294a76d3c99e01c7b7e4ee"
Fixed #13721 -- Added UploadedFile.content_type_extra.
Thanks Waldemar Kornewald and mvschaik for work on the patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:21>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: mvschaik
Type: New feature | Status: closed
Component: File uploads/storage | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"d3e33fff12266b51ab1488f7094855aef6061e9e"]:
{{{
#!CommitTicketReference repository=""
revision="d3e33fff12266b51ab1488f7094855aef6061e9e"
Made content_type_extra optional for TemporaryUploadedFile and
MemoryUploadedFile.
This provides better backwards compatibility for those constructing these
objects manually.
Refs #13721.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:22>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: mvschaik
Type: New feature | Status: closed
Component: File uploads/storage | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Gabe):
Hi guys!
I'm using Django 1.5 with Python 2.7 running in Google App Engine. I got
into this project recently, the former programmers didn't use the webapp
framework, but now I have to be able to make file upload possible with
large files (GAE doesn't allow more than 1 MB). I tried to make blobstore
work, but I couldn't, then I started looking into this stuff and found
this patch. Is it possible to make this patch work with GAE?
Thanks in advance!
Gabe
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:23>
Django
--------------------------------------+------------------------------------
Reporter: wkornewald | Owner: mvschaik
Type: New feature | Status: closed
Component: File uploads/storage | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by timo):
Hi Gabe, this ticket trackers isn't a support channel. Please see
https://docs.djangoproject.com/en/stable/faq/help/ for ways to get help.
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/13721#comment:24>