[Django] #25816: made sure that properties of SpatialRefSysMixin return the same value whether or not GDAL is installed

54 views
Skip to first unread message

Django

unread,
Nov 25, 2015, 2:52:06 PM11/25/15
to django-...@googlegroups.com
#25816: made sure that properties of SpatialRefSysMixin return the same value
whether or not GDAL is installed
--------------------------------------+--------------------
Reporter: sir-sigurd | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------


--
Ticket URL: <https://code.djangoproject.com/ticket/25816>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 25, 2015, 2:52:11 PM11/25/15
to django-...@googlegroups.com
#25816: made sure that properties of SpatialRefSysMixin return the same value
whether or not GDAL is installed
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by sir-sigurd):

* owner: nobody => sir-sigurd
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25816#comment:1>

Django

unread,
Nov 25, 2015, 4:37:07 PM11/25/15
to django-...@googlegroups.com
#25816: make sure that properties of SpatialRefSysMixin return the same value

whether or not GDAL is installed
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted


Comment:

I assume it's a good idea, but it's helpful to include a little background
information in the ticket description for posterity.

--
Ticket URL: <https://code.djangoproject.com/ticket/25816#comment:2>

Django

unread,
Nov 30, 2015, 1:50:40 AM11/30/15
to django-...@googlegroups.com
#25816: make sure that properties of SpatialRefSysMixin return the same value

whether or not GDAL is installed
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by sir-sigurd:

Old description:

New description:

At this moment there are several properties of SpatialRefSysMixin that use
some fallback code if GDAL is not installed. In several cases returned
value is obviously differs depending on whether or not GDAL is installed,
for example `angular_units` property returns float with GDAL and string
without it. I think that we need to add test to check that returned values
are the same and fix fallback code if it doesn't require much work or
could lead to some bugs.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/25816#comment:3>

Django

unread,
Jun 9, 2016, 10:49:05 AM6/9/16
to django-...@googlegroups.com
#25816: make sure that properties of SpatialRefSysMixin return the same value

whether or not GDAL is installed
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by sir-sigurd):

[https://github.com/django/django/pull/6751 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/25816#comment:4>

Django

unread,
Jun 9, 2016, 10:49:17 AM6/9/16
to django-...@googlegroups.com
#25816: make sure that properties of SpatialRefSysMixin return the same value

whether or not GDAL is installed
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by sir-sigurd):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25816#comment:5>

Django

unread,
Jun 9, 2016, 12:34:47 PM6/9/16
to django-...@googlegroups.com
#25816: make sure that properties of SpatialRefSysMixin return the same value

whether or not GDAL is installed
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25816#comment:6>

Django

unread,
Jun 16, 2016, 2:36:49 PM6/16/16
to django-...@googlegroups.com
#25816: make sure that properties of SpatialRefSysMixin return the same value

whether or not GDAL is installed
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: wontfix

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: assigned => closed
* resolution: => wontfix


Comment:

Closing as wontfix since GDAL will become a required dependency (#26753).

--
Ticket URL: <https://code.djangoproject.com/ticket/25816#comment:7>

Reply all
Reply to author
Forward
0 new messages