[Django] #30393: Add validation to target of startapp command

6 views
Skip to first unread message

Django

unread,
Apr 23, 2019, 10:47:09 PM4/23/19
to django-...@googlegroups.com
#30393: Add validation to target of startapp command
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Type: Bug | Status: assigned
Component: Core | Version: master
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
When someone calls `startapp` command with a target argument, The app will
overlay on the target directory.
If the target directory has invalid name, the app can not be imported.
So, I think it would be good to add validation on target directory's name
like app name validation.

--
Ticket URL: <https://code.djangoproject.com/ticket/30393>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 23, 2019, 10:52:31 PM4/23/19
to django-...@googlegroups.com
#30393: Add validation to target of startapp command
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: nobody
Type: Bug | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by oliver):

https://github.com/django/django/pull/11270

--
Ticket URL: <https://code.djangoproject.com/ticket/30393#comment:1>

Django

unread,
Apr 24, 2019, 1:22:15 AM4/24/19
to django-...@googlegroups.com
#30393: Add validation of target argument in startapp command.
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: oliver
Type: | Status: assigned
Cleanup/optimization |

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* owner: nobody => oliver
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted


Comment:

[https://github.com/django/django/pull/11270 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/30393#comment:2>

Django

unread,
Apr 24, 2019, 2:23:08 AM4/24/19
to django-...@googlegroups.com
#30393: Add validation of target argument in startapp command.
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: oliver
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30393#comment:3>

Django

unread,
Apr 25, 2019, 3:17:27 AM4/25/19
to django-...@googlegroups.com
#30393: Add validation of target argument in startapp command.
-------------------------------------+-------------------------------------
Reporter: oliver | Owner: oliver
Type: | Status: closed

Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"fc9566d42daf28cdaa25a5db1b5ade253ceb064f" fc9566d]:
{{{
#!CommitTicketReference repository=""
revision="fc9566d42daf28cdaa25a5db1b5ade253ceb064f"
Fixed #30393 -- Added validation of startapp's directory option.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30393#comment:4>

Reply all
Reply to author
Forward
0 new messages