[Django] #32560: Make --pdb cooperate with --buffer

0 views
Skip to first unread message

Django

unread,
Mar 17, 2021, 7:19:18 AM3/17/21
to django-...@googlegroups.com
#32560: Make --pdb cooperate with --buffer
---------------------------------------------+--------------------------
Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+--------------------------
When running `test --buffer --pdb`, a failure will open pdb but its output
isn't seen:

{{{
$ ./manage.py test --buffer --pdb
Testing against Django installed in
'/Users/chainz/Documents/Projects/django/django'
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
...............F
}}}

Since `stdin` isn't patched, one can enter commands into PDB but not see
the output, which is kind of useless. It's also really unclear how to
recover, since Ctrl-C doesn't work on the PDB prompt.

The solution would be to undo `--buffer`'s patching before opening PDB.

--
Ticket URL: <https://code.djangoproject.com/ticket/32560>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 17, 2021, 7:28:42 AM3/17/21
to django-...@googlegroups.com
#32560: Make --pdb cooperate with --buffer
-----------------------------------+--------------------------------------

Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Adam Johnson):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32560#comment:1>

Django

unread,
Mar 17, 2021, 8:15:42 AM3/17/21
to django-...@googlegroups.com
#32560: Make --pdb cooperate with --buffer
-----------------------------------+------------------------------------

Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 0 => 1
* version: dev => 3.1
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


Comment:

Thanks for the report. Marking as a release blocker because it's a bug in
the new feature (see #27430 and 9e565386d3fafc8cc15d07095e50d574e5f53802).

--
Ticket URL: <https://code.djangoproject.com/ticket/32560#comment:2>

Django

unread,
Mar 17, 2021, 3:58:02 PM3/17/21
to django-...@googlegroups.com
#32560: Make --pdb cooperate with --buffer
-------------------------------------+-------------------------------------

Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: assigned
Component: Testing framework | Version: 3.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32560#comment:3>

Django

unread,
Mar 17, 2021, 4:51:29 PM3/17/21
to django-...@googlegroups.com
#32560: Make --pdb cooperate with --buffer
-------------------------------------+-------------------------------------

Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: closed

Component: Testing framework | Version: 3.1
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"45814af6197cfd8f4dc72ee43b90ecde305a1d5a" 45814af]:
{{{
#!CommitTicketReference repository=""
revision="45814af6197cfd8f4dc72ee43b90ecde305a1d5a"
Fixed #32560 -- Fixed test runner with --pdb and --buffer on fail/error.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32560#comment:4>

Django

unread,
Mar 17, 2021, 4:51:59 PM3/17/21
to django-...@googlegroups.com
#32560: Make --pdb cooperate with --buffer
-------------------------------------+-------------------------------------

Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: closed
Component: Testing framework | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"46bdc3eaf08d24d5fad3823bb75f5f47b9ede1a9" 46bdc3e]:
{{{
#!CommitTicketReference repository=""
revision="46bdc3eaf08d24d5fad3823bb75f5f47b9ede1a9"
[3.2.x] Fixed #32560 -- Fixed test runner with --pdb and --buffer on
fail/error.

Backport of 45814af6197cfd8f4dc72ee43b90ecde305a1d5a from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32560#comment:5>

Django

unread,
Mar 17, 2021, 4:52:24 PM3/17/21
to django-...@googlegroups.com
#32560: Make --pdb cooperate with --buffer
-------------------------------------+-------------------------------------

Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: closed
Component: Testing framework | Version: 3.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"95ee8fecb53c27ef3a6f5feefb04d744dc8b894b" 95ee8fec]:
{{{
#!CommitTicketReference repository=""
revision="95ee8fecb53c27ef3a6f5feefb04d744dc8b894b"
[3.1.x] Fixed #32560 -- Fixed test runner with --pdb and --buffer on
fail/error.

Backport of 45814af6197cfd8f4dc72ee43b90ecde305a1d5a from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32560#comment:6>

Reply all
Reply to author
Forward
0 new messages