[Django] #30316: Include default logging dictConfig in documentation

18 views
Skip to first unread message

Django

unread,
Apr 2, 2019, 3:24:29 PM4/2/19
to django-...@googlegroups.com
#30316: Include default logging dictConfig in documentation
-----------------------------------------+------------------------
Reporter: Andrew Badr | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
When people want to customize Django's logging, my guess is that they'll
most often want to start by changing something about the default logging
setup. Toward this end, it would be helpful if the Django dogs included a
dictConfig for the default logging setup. Instead, the docs *describe* the
default settings (https://docs.djangoproject.com/en/2.1/topics/logging
/#default-logging-configuration), and give dictConfigs for several other
possible configurations for logging
(https://docs.djangoproject.com/en/2.1/topics/logging/#configuring-
logging).

--
Ticket URL: <https://code.djangoproject.com/ticket/30316>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 2, 2019, 3:24:50 PM4/2/19
to django-...@googlegroups.com
#30316: Include default logging dictConfig in documentation
-------------------------------+--------------------------------------

Reporter: Andrew Badr | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Andrew Badr):

* needs_docs: 0 => 1
* easy: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:1>

Django

unread,
Apr 3, 2019, 3:49:11 AM4/3/19
to django-...@googlegroups.com
#30316: Include default logging dictConfig in documentation
--------------------------------------+------------------------------------

Reporter: Andrew Badr | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

* component: Uncategorized => Documentation
* version: 2.2 => master
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


Comment:

I don't think copying the full config would be great. There are already
lots of examples in the doc for people to use.

However... getting people to look at the source is always worth is so a
single line link to `django/utils/log.py` — ''"For Reference the default
logging config is defined in..."'' (See
a68c029e224cebe540da7447dbbd27993b4aa793 for `source` extlink examples.) —
would be good.

--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:2>

Django

unread,
Apr 3, 2019, 3:49:29 AM4/3/19
to django-...@googlegroups.com
#30316: Link to default logging dictConfig in documentation
--------------------------------------+------------------------------------

Reporter: Andrew Badr | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:3>

Django

unread,
Apr 10, 2019, 2:27:49 PM4/10/19
to django-...@googlegroups.com
#30316: Link to default logging dictConfig in documentation
-------------------------------------+-------------------------------------
Reporter: Andrew Badr | Owner: Ahisahar
Type: | Pretel
Cleanup/optimization | Status: assigned

Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahisahar Pretel):

* status: new => assigned
* owner: nobody => Ahisahar Pretel


Comment:

Hi, this is my first easy picking fix. I will assign the issue to myself
and submit the PR this evening if that is ok.

--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:4>

Django

unread,
Apr 14, 2019, 6:38:53 AM4/14/19
to django-...@googlegroups.com
#30316: Link to default logging dictConfig in documentation
-------------------------------------+-------------------------------------
Reporter: Andrew Badr | Owner: Ahisahar
Type: | Pretel
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by jonnung:

Old description:

> When people want to customize Django's logging, my guess is that they'll
> most often want to start by changing something about the default logging
> setup. Toward this end, it would be helpful if the Django dogs included a
> dictConfig for the default logging setup. Instead, the docs *describe*
> the default settings
> (https://docs.djangoproject.com/en/2.1/topics/logging/#default-logging-
> configuration), and give dictConfigs for several other possible
> configurations for logging
> (https://docs.djangoproject.com/en/2.1/topics/logging/#configuring-
> logging).

New description:

When people want to customize Django's logging, my guess is that they'll
most often want to start by changing something about the default logging

setup. Toward this end, it would be helpful if the Django docs included a


dictConfig for the default logging setup. Instead, the docs *describe* the
default settings (https://docs.djangoproject.com/en/2.1/topics/logging
/#default-logging-configuration), and give dictConfigs for several other
possible configurations for logging
(https://docs.djangoproject.com/en/2.1/topics/logging/#configuring-
logging).

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:5>

Django

unread,
May 7, 2019, 3:26:58 PM5/7/19
to django-...@googlegroups.com
#30316: Link to default logging dictConfig in documentation
-------------------------------------+-------------------------------------
Reporter: Andrew Badr | Owner: Ahisahar
Type: | Pretel
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ahisahar Pretel):

* has_patch: 0 => 1


Comment:

Patch link https://github.com/django/django/pull/11338

--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:6>

Django

unread,
May 9, 2019, 2:52:35 PM5/9/19
to django-...@googlegroups.com
#30316: Link to default logging dictConfig in documentation
-------------------------------------+-------------------------------------
Reporter: Andrew Badr | Owner: Ahisahar
Type: | Pretel
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* needs_docs: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:7>

Django

unread,
May 15, 2019, 6:37:06 AM5/15/19
to django-...@googlegroups.com
#30316: Link to default logging dictConfig in documentation
-------------------------------------+-------------------------------------
Reporter: Andrew Badr | Owner: Ahisahar
Type: | Pretel
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"717362d810955b9514e2ccd989f8a1647c9d7a00" 717362d8]:
{{{
#!CommitTicketReference repository=""
revision="717362d810955b9514e2ccd989f8a1647c9d7a00"
Fixed #30316 -- Added source code link to the default logging
configuration in logging docs.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:8>

Django

unread,
May 15, 2019, 6:38:06 AM5/15/19
to django-...@googlegroups.com
#30316: Link to default logging dictConfig in documentation
-------------------------------------+-------------------------------------
Reporter: Andrew Badr | Owner: Ahisahar
Type: | Pretel
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"f6febbc078aed627ec937f7e56876dc208a5e339" f6febbc0]:
{{{
#!CommitTicketReference repository=""
revision="f6febbc078aed627ec937f7e56876dc208a5e339"
[2.2.x] Fixed #30316 -- Added source code link to the default logging
configuration in logging docs.

Backport of 717362d810955b9514e2ccd989f8a1647c9d7a00 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30316#comment:9>

Reply all
Reply to author
Forward
0 new messages