[Django] #25865: OSMGeoAdmin should require GDAL only if model has fields with SRID that differs from map srid
Django
differs from map srid
-------------------------------+--------------------
Reporter: sir-sigurd | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/25865>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-sigurd
Type: Uncategorized | Status: assigned
Component: GIS | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sir-sigurd):
* status: new => assigned
* needs_docs: => 0
* owner: nobody => sir-sigurd
* needs_tests: => 0
* needs_better_patch: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:1>
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-sigurd
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sir-sigurd):
* has_patch: 0 => 1
Comment:
PR -- https://github.com/django/django/pull/5770
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:2>
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-sigurd
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Description changed by sir-sigurd:
Old description:
New description:
ATM `OSMGeoAdmin` raises exception while initialization if GDAL isn't
available, that seems to be too strong check because GDAL is not needed if
SRID of model field is the same as needed by map widget.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:3>
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-sigurd
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
I'm a bit hesitant here. Do you see many projects who store there data
with the projected spherical mercator (3857)? I'm not even sure we should
encourage that.
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:4>
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-sigurd
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by sir-sigurd):
Honestly speaking I have deal with the only GIS project =)
My position on this: if we are supporting GIS stuff running even without
GDAL we should try to minimize dependency from it as hard as we can while
this doesn't lead us to reinventing it.
I could even see imaginable use case for storing the data in 3857: to
store it along with the data in 4326 to get rid of the overhead on
transforming coordinates every time they are should be represented to the
users.
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:5>
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* type: Uncategorized => Cleanup/optimization
Comment:
It looks to me like the current error would be raised at compile time.
Will the new error be raised at compile time or only when accessing the
admin page? I think the former is much better. If the ticket is accepted,
it might be better to convert it to a system check if possible.
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:6>
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
I'll tentatively accept the ticket given it has sat on the unreviewed
queue for several weeks and mark it "patch needs improvement" until GIS
contributors decide on whether or not to move forward with it.
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:7>
Django
differs from map srid
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Component: GIS | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1f035e6283dc06ad9ab719e786944a094c7eb330" 1f035e62]:
{{{
#!CommitTicketReference repository=""
revision="1f035e6283dc06ad9ab719e786944a094c7eb330"
Fixed #25865 -- Made OSMGeoAdmin require GDAL only if transformation is
needed.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25865#comment:8>