Re: [Django] #15902: Storing current language in session/cookie

[Django]

#15902: Storing current language in session/cookie
-------------------------------------+-------------------------------------
Reporter: | Owner: msiedlarek
msiedlarek | Status: new
Type: New | Component:
feature | Internationalization
Milestone: | Severity: Normal
Version: 1.3 | Keywords: language i18n
Resolution: | session cookie
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by raymond.penners@…):

* cc: raymond.penners@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/15902#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#15902: Storing current language in session/cookie
-------------------------------------+-------------------------------------
Reporter: | Owner: msiedlarek
msiedlarek | Status: new
Type: New | Component:
feature | Internationalization
Milestone: | Severity: Normal
Version: 1.3 | Keywords: language i18n
Resolution: | session cookie
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0

UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by vzima):

* cc: vlastimil.zima@… (added)
* ui_ux: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/15902#comment:4>

[Django]

#15902: Storing current language in session/cookie
-------------------------------------+-------------------------------------

Reporter: msiedlarek | Owner:
| msiedlarek
Type: New feature | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: language i18n | Triage Stage: Accepted
session cookie |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by claudep):

* has_patch: 0 => 1
* version: 1.3 => master

Comment:

This [https://github.com/django/django/pull/7117 PR] tries to depart from
storing the user language in the session.

--
Ticket URL: <https://code.djangoproject.com/ticket/15902#comment:5>

[Django]

#15902: Storing current language in session/cookie
-------------------------------------+-------------------------------------
Reporter: msiedlarek | Owner:
| msiedlarek
Type: New feature | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: language i18n | Triage Stage: Accepted
session cookie |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by timgraham):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/15902#comment:6>

[Django]

#15902: Storing current language in session/cookie
-------------------------------------+-------------------------------------
Reporter: msiedlarek | Owner:
| msiedlarek
Type: New feature | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: language i18n | Triage Stage: Accepted
session cookie |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz):

This [https://github.com/django/django/pull/9407 PR] just adds the
language in a cookie inconditionally, so we can later deprecate and remove
language in the session with minimal backwards incompatibility (this was
discussed on the previous PR).

--
Ticket URL: <https://code.djangoproject.com/ticket/15902#comment:7>

[Django]

#15902: Storing current language in session/cookie
-------------------------------------+-------------------------------------
Reporter: msiedlarek | Owner:
| msiedlarek
Type: New feature | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: language i18n | Triage Stage: Accepted
session cookie |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"b3cd9fb18ba127c067a4f3c79a32e51c8d8cc6ae" b3cd9fb1]:
{{{
#!CommitTicketReference repository=""
revision="b3cd9fb18ba127c067a4f3c79a32e51c8d8cc6ae"
Refs #15902 -- Made set_language() view always set the current language in
a cookie.

The plan is to later deprecate/remove storing the language in the session.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15902#comment:8>

[Django]

#15902: Storing current language in session/cookie
-------------------------------------+-------------------------------------
Reporter: msiedlarek | Owner:
| msiedlarek
Type: New feature | Status: new
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: language i18n | Triage Stage: Accepted
session cookie |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Claude Paroz):

* needs_better_patch: 1 => 0

Comment:

I updated the pull request (https://github.com/django/django/pull/10875).
I was not sure if we meant adding a deprecation in 2.2, but I guess it's
late now.

--
Ticket URL: <https://code.djangoproject.com/ticket/15902#comment:9>