[Django] #25938: deduplicate GEOSBase and GDALBase
Django
--------------------------------------+--------------------
Reporter: sir-sigurd | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
`gis.gdal.base.GDALBase` and `gis.geos.base.GEOSBase` classes have almost
the same implementation, their subclasses uses the same pattern for
`__del__()` method, so all this logic should be factored out to a common
class.
P.S.: suggestions for the name of this new common class are welcome.
--
Ticket URL: <https://code.djangoproject.com/ticket/25938>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sir-sigurd):
* status: new => assigned
* owner: nobody => sir-sigurd
* needs_docs: => 0
* needs_tests: => 0
* needs_better_patch: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:1>
Django
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
Comment:
Maybe a name like `CPointerBase`?
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:2>
Django
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by sir-sigurd):
`CPointerBase` looks better than my `PtrBase`.
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:3>
Django
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sir-sigurd):
* has_patch: 0 => 1
Comment:
PR -- https://github.com/django/django/pull/5828
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:4>
Django
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:5>
Django
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:6>
Django
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Sergey Fedoseev):
* needs_better_patch: 1 => 0
Comment:
[https://github.com/django/django/pull/7660 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:7>
Django
Reporter: Sergey Fedoseev | Owner: Sergey
Type: | Fedoseev
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"b01ceae843c74062460fdf2f8e9fd3c5cc75ea45" b01ceae8]:
{{{
#!CommitTicketReference repository=""
revision="b01ceae843c74062460fdf2f8e9fd3c5cc75ea45"
Fixed #25938 -- Factored out CPointerBase base class for
GEOSBase/GDALBase.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25938#comment:8>