[Django] #31370: Make parallel test runner work with buffer option

7 views
Skip to first unread message

Django

unread,
Mar 17, 2020, 4:20:15 AM3/17/20
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: nobody
(Chainz) Johnson |
Type: New | Status: assigned
feature |
Component: Testing | Version: master
framework |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
#27430 added support for unittest's --buffer option, but only when not
using --parallel. Since --parallel is normally very useful to speed up
tests, it would be good to make the options work together. I think this
can be done by copying some code from unittest into the `RemoteTestResult`
class.

--
Ticket URL: <https://code.djangoproject.com/ticket/31370>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 17, 2020, 4:49:09 AM3/17/20
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: New feature | Status: closed
Component: Testing framework | Version: master
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* cc: Baptiste Mispelon (added)
* status: assigned => closed
* resolution: => needsinfo


Comment:

I'm not sure if it's feasible (see
[https://code.djangoproject.com/ticket/27430#comment:7 comment]). I think
we need a proof of concept, before we will accept this. Would you like to
prepare a patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:1>

Django

unread,
Mar 17, 2020, 4:58:50 AM3/17/20
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: New feature | Status: closed
Component: Testing framework | Version: master
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam (Chainz) Johnson):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:2>

Django

unread,
Mar 17, 2020, 5:02:08 AM3/17/20
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam (Chainz) Johnson):

* status: closed => new
* resolution: needsinfo =>


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:3>

Django

unread,
Mar 17, 2020, 5:09:44 AM3/17/20
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Adam
Johnson | (Chainz) Johnson
Type: New feature | Status: assigned

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* owner: nobody => Adam (Chainz) Johnson
* status: new => assigned
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:4>

Django

unread,
Jul 30, 2020, 4:14:51 AM7/30/20
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Adam
Johnson | (Chainz) Johnson
Type: New feature | Status: assigned
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:5>

Django

unread,
Mar 16, 2021, 8:47:39 AM3/16/21
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam

| Johnson
Type: New feature | Status: assigned
Component: Testing framework | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:6>

Django

unread,
Mar 18, 2021, 3:07:48 AM3/18/21
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:7>

Django

unread,
Mar 18, 2021, 6:57:37 AM3/18/21
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:8>

Django

unread,
Mar 18, 2021, 7:42:25 AM3/18/21
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:9>

Django

unread,
Mar 18, 2021, 11:28:41 AM3/18/21
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"e3bca22e7e572b0274a0814c7869c899d7b544e0" e3bca22e]:
{{{
#!CommitTicketReference repository=""
revision="e3bca22e7e572b0274a0814c7869c899d7b544e0"
Refs #31370 -- Made RemoteTestResult subclass unittest.TestResult.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:11>

Django

unread,
Mar 18, 2021, 11:28:42 AM3/18/21
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"92975bcd5f6281d6124f30cd4a71e0adedd78781" 92975bcd]:
{{{
#!CommitTicketReference repository=""
revision="92975bcd5f6281d6124f30cd4a71e0adedd78781"
Refs #31370 -- Added test for pickling RemoteTestResult.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:10>

Django

unread,
Mar 18, 2021, 11:28:42 AM3/18/21
to django-...@googlegroups.com
#31370: Make parallel test runner work with buffer option.
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: New feature | Status: closed

Component: Testing framework | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed

* resolution: => fixed


Comment:

In [changeset:"f6713cda89d323565cfdc867c977c3363edcfc3c" f6713cda]:
{{{
#!CommitTicketReference repository=""
revision="f6713cda89d323565cfdc867c977c3363edcfc3c"
Fixed #31370 -- Added support for parallel tests with --buffer.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31370#comment:12>

Reply all
Reply to author
Forward
0 new messages