[Django] #28925: durations-only expressions doesn't work on SQLite and MySQL

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------
Reporter: Sergey | Owner: nobody
Fedoseev |
Type: Bug | Status: new
Component: Database | Version: 1.8
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
{{{
class Experiment(models.Model):
estimated_time = models.DurationField()

list(Experiment.objects.annotate(duration=F('estimated_time') +
datime.timedelta(1)))
}}}

{{{
Traceback (most recent call last):
File "/home/sergey/dev/django/tests/expressions/tests.py", line 1218, in
test_duration_expressions
list(Experiment.objects.annotate(duration=F('estimated_time') +
delta))
File "/home/sergey/dev/django/django/db/models/query.py", line 269, in
__iter__
self._fetch_all()
File "/home/sergey/dev/django/django/db/models/query.py", line 1172, in
_fetch_all
self._result_cache = list(self._iterable_class(self))
File "/home/sergey/dev/django/django/db/models/query.py", line 63, in
__iter__
for row in compiler.results_iter(results):
File "/home/sergey/dev/django/django/db/models/sql/compiler.py", line
998, in apply_converters
value = converter(value, expression, connection)
File "/home/sergey/dev/django/django/db/backends/base/operations.py",
line 571, in convert_durationfield_value
value = str(decimal.Decimal(value) / decimal.Decimal(1000000))
decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28925>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sergey Fedoseev):

* status: new => assigned
* owner: nobody => Sergey Fedoseev

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:1>

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sergey Fedoseev):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/9462 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:2>

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Simon Charette):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:3>

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* needs_better_patch: 0 => 1

Comment:

There are test failures on the PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:4>

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Simon Charette):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:5>

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned

Component: Database layer | Version: master

(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* version: 1.8 => master
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:6>

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"9d752dabe38602a71452ed8c23253e780a40a560" 9d752dab]:
{{{
#!CommitTicketReference repository=""
revision="9d752dabe38602a71452ed8c23253e780a40a560"
Refs #28925 -- Simplified CombinedExpression.as_sql() a bit.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:7>

[Django]

#28925: durations-only expressions doesn't work on SQLite and MySQL
-------------------------------------+-------------------------------------

Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev

Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"dd5aa8cb5ffc0a89c4b9b8dee45c1c919d203489" dd5aa8cb]:
{{{
#!CommitTicketReference repository=""
revision="dd5aa8cb5ffc0a89c4b9b8dee45c1c919d203489"
Fixed #28925 -- Fixed durations-only expressions crash on SQLite and
MySQL.

This removes also unused DatabaseOperations.date_interval_sql().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28925#comment:8>