[Django] #31825: RenameField with db_column defined drop and recreate the same constrainsts
Django
------------------------------------------------+------------------------
Reporter: iurisilvio | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
RenameField with db_column should be a noop because it is only the Dajngo
--
Ticket URL: <https://code.djangoproject.com/ticket/31825>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: iurisilvio | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by iurisilvio:
Old description:
> RenameField with db_column should be a noop because it is only the Dajngo
New description:
RenameField with db_column should be a noop because it is only the Django
column that changed, the database still have the same db_column.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: iurisilvio | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by iurisilvio):
I did a pull request here. https://github.com/django/django/pull/13236
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: iurisilvio | Owner:
Cleanup/optimization | Status: assigned
Component: Migrations | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by iurisilvio):
* owner: nobody => iurisilvio
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Iuri de Silvio):
* version: 3.0 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* cc: Simon Charette (added)
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Thanks. See related ticket when
[https://code.djangoproject.com/ticket/29245#comment:1 Simon pointed out]
that such change (3 & 4) should be a noop.
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Iuri de Silvio):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Iuri de Silvio):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7f4c9222dfe2f28ff8a7ffc56c28ccbadf19cf6f" 7f4c9222]:
{{{
#!CommitTicketReference repository=""
revision="7f4c9222dfe2f28ff8a7ffc56c28ccbadf19cf6f"
Fixed #31825 -- Made RenameField operation a noop for fields with
db_column.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31825#comment:11>