Re: [Django] #8918: FileField upload_to should not be required for custom backends
Django
-------------------------------------+-------------------------------------
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
Component: File | Version: master
uploads/storage | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: FileField, files, | Needs documentation: 0
upload, S3, upload_to | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by jacob):
* stage: Design decision needed => Accepted
Comment:
Despite the portability issues, I still think upload_to should be
optional.
--
Ticket URL: <https://code.djangoproject.com/ticket/8918#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: leahculver | Owner: nobody
Type: New feature | Status: new
Component: File | Version: master
uploads/storage | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: FileField, files, | Needs documentation: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):
* needs_better_patch: 0 => 1
* easy: 0 => 1
Comment:
Patch needs to be updated to apply cleanly and the change should be
mentioned in the release notes (docs/releases/1.7.txt). These changes
should be suitable for a first-time committer.
--
Ticket URL: <https://code.djangoproject.com/ticket/8918#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: leahculver | Owner: nobody
Component: File | Version: master
uploads/storage | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: FileField, files, | Needs documentation: 0
upload, S3, upload_to | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"945e033a6964c8c83c1c5ce5f188baf41a7a7701"]:
{{{
#!CommitTicketReference repository=""
revision="945e033a6964c8c83c1c5ce5f188baf41a7a7701"
Fixed #8918 -- Made FileField.upload_to optional.
Thanks leahculver for the suggestion and dc and vajrasky for work
on the patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/8918#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: leahculver | Owner: nobody
Type: New feature | Status: closed
Component: File | Version: master
uploads/storage | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: FileField, files, | Needs documentation: 0
upload, S3, upload_to | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by anonymous):
Amazing. Thanks everyone!!
--
Ticket URL: <https://code.djangoproject.com/ticket/8918#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: leahculver | Owner: nobody
Type: New feature | Status: closed
Component: File | Version: master
uploads/storage | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: FileField, files, | Needs documentation: 0
upload, S3, upload_to | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by Ramiro Morales <ramiro@…>):
In [changeset:"8ab5f1fe4750105dae734764baed54bd4d22792b"]:
{{{
#!CommitTicketReference repository=""
revision="8ab5f1fe4750105dae734764baed54bd4d22792b"
Close file after tests added in 945e033a69.
Avoids failures on Windows. Refs #8918.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/8918#comment:17>