Re: [Django] #8760: forms.ModelMultipleChoiceField should use "invalid_list" as error message key
Django
key
--------------------------------------+------------------------------------
Reporter: durdinator | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by giuliettamasina):
Should this change happen? The comments are ambiguous :)
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
key
--------------------------------------+------------------------------------
Reporter: durdinator | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* has_patch: 0 => 1
Comment:
The implementation isn't difficult (see attached patch). The question is
whether or not we accept this as a backwards incompatible change (to be
documented if so) or try for some deprecation path. I'm not sure how a
deprecation would work.
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:8>
Django
key
--------------------------------------+------------------------------------
Reporter: durdinator | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* Attachment "8760.diff" added.
--
Ticket URL: <https://code.djangoproject.com/ticket/8760>
Django
key
--------------------------------------+------------------------------------
Reporter: durdinator | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:9>
Django
key
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* status: new => assigned
* owner: nobody => hassam
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:10>
Django
key
Reporter: durdinator | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by David Smith):
* owner: nobody => David Smith
* status: new => assigned
Django
key
-------------------------------------+-------------------------------------
Reporter: durdinator | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by David Smith):
I've created a pull request with the patch that Tim provided. Making this
change only broke one test and I've provided a fix for this.
Hopefully this can help aid a decision on if we should make this change.
If we should then is it 'ok' as a breaking change or do we need to try for
a deprecation path.
From just the notes above it seems like a trivial inconsistency and not
one that anyone is particularly passionate about given how long the ticket
has been open. Therefore if it's going to cause any issues for anyone
maybe it's just best to not fix and close the ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:11>
Django
key
-------------------------------------+-------------------------------------
Reporter: durdinator | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:12>
Django
key
-------------------------------------+-------------------------------------
Reporter: durdinator | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* needs_docs: 0 => 1
Comment:
[https://github.com/django/django/pull/12532 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:13>
Django
key
-------------------------------------+-------------------------------------
Reporter: durdinator | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* needs_docs: 1 => 0
Comment:
I've now added a deprecation warning, docs and tests to this PR. So ready
for next review.
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:14>
Django
key
-------------------------------------+-------------------------------------
Reporter: durdinator | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:15>
Django
key
-------------------------------------+-------------------------------------
Reporter: durdinator | Owner: David
Type: | Smith
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: forms | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ccf32aca442feae4c765fb6133c418b4e387f428" ccf32ac]:
{{{
#!CommitTicketReference repository=""
revision="ccf32aca442feae4c765fb6133c418b4e387f428"
Fixed #8760 -- Changed ModelMultipleChoiceField to use invalid_list as a
error message key.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:16>
Django
key
-------------------------------------+-------------------------------------
Reporter: durdinator | Owner: David
Type: | Smith
Cleanup/optimization | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: forms | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"bf770cc825f1af294b3b2853b39b5b161b6a056f" bf770cc8]:
{{{
#!CommitTicketReference repository=""
revision="bf770cc825f1af294b3b2853b39b5b161b6a056f"
Refs #8760 -- Removed "list" message for ModelMultipleChoiceField per
deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/8760#comment:17>