[Django] #25876: deprecate OGRGeometry.transform_to() method

7 views
Skip to first unread message

Django

unread,
Dec 7, 2015, 4:54:40 AM12/7/15
to django-...@googlegroups.com
#25876: deprecate OGRGeometry.transform_to() method
--------------------------------------+--------------------
Reporter: sir-sigurd | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
I propose to deprecate OGRGeometry.transform_to() method because it's just
an alias for OGRGeometry.transform() method, it's docstring said "For
backwards-compatibility." from it's first appearance in the code.

--
Ticket URL: <https://code.djangoproject.com/ticket/25876>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 7, 2015, 4:54:51 AM12/7/15
to django-...@googlegroups.com
#25876: deprecate OGRGeometry.transform_to() method
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by sir-sigurd):

* status: new => assigned
* needs_better_patch: => 0
* owner: nobody => sir-sigurd
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25876#comment:1>

Django

unread,
Dec 7, 2015, 6:13:17 PM12/7/15
to django-...@googlegroups.com
#25876: deprecate OGRGeometry.transform_to() method
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted


Comment:

It seems undocumented and untested -- maybe it's fine to remove without a
deprecation?

--
Ticket URL: <https://code.djangoproject.com/ticket/25876#comment:2>

Django

unread,
Dec 8, 2015, 12:01:39 AM12/8/15
to django-...@googlegroups.com
#25876: deprecate OGRGeometry.transform_to() method
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by sir-sigurd):

This seems to be fine for me.

--
Ticket URL: <https://code.djangoproject.com/ticket/25876#comment:3>

Django

unread,
Dec 8, 2015, 12:08:31 AM12/8/15
to django-...@googlegroups.com
#25876: deprecate OGRGeometry.transform_to() method
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by sir-sigurd):

* has_patch: 0 => 1


Comment:

PR -- https://github.com/django/django/pull/5787

--
Ticket URL: <https://code.djangoproject.com/ticket/25876#comment:4>

Django

unread,
Dec 8, 2015, 2:54:38 AM12/8/15
to django-...@googlegroups.com
#25876: deprecate OGRGeometry.transform_to() method
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25876#comment:5>

Django

unread,
Dec 8, 2015, 10:54:07 AM12/8/15
to django-...@googlegroups.com
#25876: deprecate OGRGeometry.transform_to() method
-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sergey Fedoseev <fedoseev.sergey@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"a8614fb438432551e52a818b5f76f48d4ac5b499" a8614fb]:
{{{
#!CommitTicketReference repository=""
revision="a8614fb438432551e52a818b5f76f48d4ac5b499"
Fixed #25876 -- Removed OGRGeometry.transform_to() backwards-compatibility
method.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25876#comment:6>

Django

unread,
Dec 8, 2015, 10:59:27 AM12/8/15
to django-...@googlegroups.com
#25876: Remove unused/untested OGRGeometry.transform_to() method

-------------------------------------+-------------------------------------
Reporter: sir-sigurd | Owner: sir-
Type: | sigurd
Cleanup/optimization | Status: closed
Component: GIS | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/25876#comment:7>

Reply all
Reply to author
Forward
0 new messages