[Django] #28508: Error views set background-color bot not foreground color
Django
-----------------------------------------+------------------------
Reporter: John Dallahan | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-----------------------------------------+------------------------
CSRF error pages and 404 pages do not set the text color in their inline
styles, but they set background-color, making it annoying to view them
with dark GTK themes. Relevant lines:
https://github.com/django/django/blob/master/django/views/templates/technical_404.html#L11
https://github.com/django/django/blob/master/django/views/csrf.py#L26
The 500 page does have it set, though:
https://github.com/django/django/blob/master/django/views/templates/technical_500.html#L12
--
Ticket URL: <https://code.djangoproject.com/ticket/28508>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: John Dallahan | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by John Dallahan):
* Attachment "Screen Shot 2017-08-19 at 14.58.43.png" added.
What the page looks like in my browser
Django
Reporter: John Dallahan | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+------------------------------------
Changes (by Claude Paroz):
* component: Uncategorized => Core (Other)
* easy: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28508#comment:1>
Django
Reporter: John Dallahan | Owner: Darius Azimi
Type: Bug | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+----------------------------------------
Changes (by Darius Azimi):
* owner: nobody => Darius Azimi
* status: new => assigned
Comment:
To make sure I understand it correctly, using the same text and background
from technical_500 on other pages of csrf and technical_404 would correct
this issue?
Replying to [ticket:28508 John Dallahan]:
> CSRF error pages and 404 pages do not set the text color in their inline
styles, but they set background-color, making it annoying to view them
with dark GTK themes. Relevant lines:
>
https://github.com/django/django/blob/master/django/views/templates/technical_404.html#L11
> https://github.com/django/django/blob/master/django/views/csrf.py#L26
> The 500 page does have it set, though:
>
https://github.com/django/django/blob/master/django/views/templates/technical_500.html#L12
--
Ticket URL: <https://code.djangoproject.com/ticket/28508#comment:2>
Django
Reporter: John Dallahan | Owner: Darius Azimi
Type: Bug | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+----------------------------------------
Comment (by John Dallahan):
Yes, that should fix the issue. I recommend using a common template which
is extended by error views, though.
--
Ticket URL: <https://code.djangoproject.com/ticket/28508#comment:3>
Django
Reporter: John Dallahan | Owner: Darius Azimi
Type: Bug | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+----------------------------------------
Comment (by Abhishek):
this ticket needs review
--
Ticket URL: <https://code.djangoproject.com/ticket/28508#comment:4>
Django
Reporter: John Dallahan | Owner: Darius Azimi
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+----------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"347551c2a1bc78b3a5886be6adde0c8151001acc" 347551c2]:
{{{
#!CommitTicketReference repository=""
revision="347551c2a1bc78b3a5886be6adde0c8151001acc"
Fixed #28508 -- Set the foreground color to black in CSRF and 404 error
templates.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28508#comment:5>
Django
---------------------------------+----------------------------------------
Reporter: John Dallahan | Owner: Darius Azimi
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
---------------------------------+----------------------------------------
Changes (by Tim Graham):
* component: Core (Other) => Error reporting
--
Ticket URL: <https://code.djangoproject.com/ticket/28508#comment:6>