[Django] #24474: Make display for null fields in Django admin configurable through settings
Django
-------------------------------+--------------------
Reporter: gannetson | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Display value for null fields is '-' now. It would be nice if this is
configurable in settings. '-' can be a bit hard to click if you use it in
a list filter.
This relates to changes made in
https://code.djangoproject.com/ticket/24226.
http://stackoverflow.com/questions/18324030/how-to-change-empty-
changelist-value-in-django-admin
http://stackoverflow.com/questions/28174881/in-the-django-admin-
changelist-how-do-i-display-a-blank-space-instead-of-the-
de?noredirect=1#comment44719629_28174881
--
Ticket URL: <https://code.djangoproject.com/ticket/24474>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: gannetson | Owner: gannetson
Type: Uncategorized | Status: assigned
Component: Uncategorized | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gannetson):
* owner: nobody => gannetson
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:1>
Django
Reporter: gannetson | Owner: gannetson
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gannetson):
* component: Uncategorized => contrib.admin
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:2>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* version: 1.7 => master
* type: Uncategorized => New feature
* stage: Unreviewed => Accepted
Comment:
By settings, I think attributes of `ModelAdmin` and `AdminSite` would
probably be the way to go.
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:3>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gannetson):
* needs_docs: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:4>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gannetson):
* needs_docs: 1 => 0
* has_patch: 0 => 1
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:5>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Reviewed PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:6>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by gannetson):
Applied suggested changes. PR ready for new review.
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:7>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:8>
Django
Reporter: gannetson | Owner: gannetson
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"72f769f494822981db6df9524b92a2d86f8e69fe" 72f769f4]:
{{{
#!CommitTicketReference repository=""
revision="72f769f494822981db6df9524b92a2d86f8e69fe"
Fixed #24474 -- Allowed configuring the admin's empty change list value.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:9>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"1273a7a0e808a43ce7a344bbf36d55b9436ecf41" 1273a7a0]:
{{{
#!CommitTicketReference repository=""
revision="1273a7a0e808a43ce7a344bbf36d55b9436ecf41"
Revert "Fixed #24474 -- Allowed configuring the admin's empty change list
value."
This reverts commit 72f769f494822981db6df9524b92a2d86f8e69fe.
There are several test failures that need to be fixed.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:10>
Django
Reporter: gannetson | Owner: gannetson
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: closed => new
* needs_better_patch: 0 => 1
* resolution: fixed =>
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:11>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by gannetson):
I see the failing tests now. I'll look into this.
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:12>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by gannetson):
Django Sprint Cardiff! I'm continuing this ticket now.
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:13>
Django
Reporter: gannetson | Owner: gannetson
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by gannetson):
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:14>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
Comment:
Looks good, pending a cosmetic comment.
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:15>
Django
Reporter: gannetson | Owner: gannetson
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by gannetson):
Do you mean this one?
https://github.com/gannetson/django/commit/fcb527df09a8087763725e123255eebca2474e76
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:16>
Django
Reporter: gannetson | Owner: gannetson
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"0207bdd2d4157c542c981264c86706b78ca246e9" 0207bdd]:
{{{
#!CommitTicketReference repository=""
revision="0207bdd2d4157c542c981264c86706b78ca246e9"
Fixed #24474 -- Allowed configuring the admin's empty change list value.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:17>
Django
Reporter: Loek van Gent | Owner: Loek van
| Gent
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by GitHub <noreply@…>):
In [changeset:"67a1ae68a833358e4b5bf2677e3f9f5719443bea" 67a1ae6]:
{{{
#!CommitTicketReference repository=""
revision="67a1ae68a833358e4b5bf2677e3f9f5719443bea"
Refs #24474 -- Changed AdminSite.empty_value_display property to an
attribute.
This was implemented with a property getter and setter when introduced
in 0207bdd2d4157c542c981264c86706b78ca246e9.
There is nothing special occurring here though - a simple read from and
assign to the underlying private attribute.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24474#comment:18>