[Django] #21675: Provide an AppConfig for contrib apps with a translatable verbose_name

4 views
Skip to first unread message

Django

unread,
Dec 26, 2013, 3:11:54 PM12/26/13
to django-...@googlegroups.com
#21675: Provide an AppConfig for contrib apps with a translatable verbose_name
----------------------------------------+-----------------------------
Reporter: aaugustin | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords: app-loading
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+-----------------------------
That would make sense if we want to promote the use of AppConfig
subclasses in INSTALLED_APPS.

It involves:
- picking good verbose names in English
- creating simple AppConfig modules
- updating the documentation

--
Ticket URL: <https://code.djangoproject.com/ticket/21675>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 30, 2013, 6:49:08 AM12/30/13
to django-...@googlegroups.com
#21675: Provide an AppConfig for contrib apps with a translatable verbose_name
------------------------------+------------------------------------

Reporter: aaugustin | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: app-loading | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------

Comment (by aaugustin):

When #21676 is done, we should try to move setup code in AppConfigs too.
As is, it won't work for people still using the app name in
INSTALLED_APPS, unless we reintroduce some kind of autodiscovery.

--
Ticket URL: <https://code.djangoproject.com/ticket/21675#comment:2>

Django

unread,
Dec 30, 2013, 7:04:08 AM12/30/13
to django-...@googlegroups.com
#21675: Provide an AppConfig for contrib apps with a translatable verbose_name
------------------------------+------------------------------------

Reporter: aaugustin | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: app-loading | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------

Comment (by mjtamlyn):

Setup code should likely by default include `admin.site.autodiscover()` as
this clearly does not belong in a `urls.py` file.

--
Ticket URL: <https://code.djangoproject.com/ticket/21675#comment:3>

Django

unread,
Jan 4, 2014, 4:59:09 PM1/4/14
to django-...@googlegroups.com
#21675: Provide an AppConfig for contrib apps with a translatable verbose_name
------------------------------+------------------------------------

Reporter: aaugustin | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: app-loading | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Changes (by aaugustin):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/2145 creates AppConfig classes for
all contrib apps.

The admin will use verbose_name for apps that have models, and admindocs
too once #21685 is fixed.

For apps that don't have models, I don't think this change has any effect
at this point.

But I included all apps in the patch for consistency. At least we have
them if we introduce features that could take advantage of them.

This patch doesn't address the documentation; I don't know how much we
want to promote usage of app configs; I'll discuss it on django-developers
first. Even if we don't document it at all I think it's worth having these
classes.

--
Ticket URL: <https://code.djangoproject.com/ticket/21675#comment:4>

Django

unread,
Jan 5, 2014, 4:35:34 PM1/5/14
to django-...@googlegroups.com
#21675: Provide an AppConfig for contrib apps with a translatable verbose_name
------------------------------+------------------------------------
Reporter: aaugustin | Owner: nobody
Type: New feature | Status: closed

Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed

Keywords: app-loading | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Changes (by Aymeric Augustin <aymeric.augustin@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"27afd302c687528ff1dc3156961e409862c6eca2"]:
{{{
#!CommitTicketReference repository=""
revision="27afd302c687528ff1dc3156961e409862c6eca2"
Fixed #21675 -- Added app configs for contrib apps.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21675#comment:5>

Reply all
Reply to author
Forward
0 new messages