[Django] #27432: showmigrations --plan should show migrations that would be applied for the given app_labels

18 views
Skip to first unread message

Django

unread,
Nov 4, 2016, 6:43:10 AM11/4/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-----------------------------------------+------------------------
Reporter: Will Hardy | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
If you call `showmigrations` with `--plan`, any `app_label`s that are also
applied are ignored. But if you run `migrate` with a given `app_label`, a
plan is followed that only applies migrations for the given app, and any
dependencies that were found along the way.

Instead of ignoring any supplied `app_label`s, it would make more sense to
behave as `migrate` does, providing a preview for a probable migration
plan.

--
Ticket URL: <https://code.djangoproject.com/ticket/27432>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 5, 2016, 7:16:34 AM11/5/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Sebastian
| Spiegel
Type: Uncategorized | Status: assigned
Component: Uncategorized | Version: 1.10
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sebastian Spiegel):

* owner: nobody => Sebastian Spiegel
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:1>

Django

unread,
Nov 5, 2016, 8:51:55 AM11/5/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Sebastian
| Spiegel
Type: New feature | Status: assigned
Component: Core (Management | Version: 1.10
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sebastian Spiegel):

* type: Uncategorized => New feature
* component: Uncategorized => Core (Management commands)
* stage: Unreviewed => Accepted


Comment:

Though documentation is explaining why `--plan` is ignoring `app_label`s:
Any supplied app labels are ignored because the plan might go beyond
those apps.
(https://docs.djangoproject.com/en/1.10/ref/django-admin/#django-admin-
showmigrations)

I agree with the reporter that `showmigrations --plan` should support app
labels. It would make it behave analogously to `migrate app_label`.

--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:2>

Django

unread,
Nov 6, 2016, 7:59:44 AM11/6/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Sebastian
| Spiegel
Type: New feature | Status: assigned
Component: Core (Management | Version: 1.10
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sebastian Spiegel):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7522 PR] ready, all tests pass
under SQLite.

--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:3>

Django

unread,
Nov 8, 2016, 7:10:38 PM11/8/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Sebastian
| Spiegel
Type: New feature | Status: assigned
Component: Core (Management | Version: master

commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Markus Holtermann):

* needs_better_patch: 0 => 1
* version: 1.10 => master


--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:4>

Django

unread,
Nov 9, 2016, 5:19:56 AM11/9/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Sebastian
| Spiegel
Type: New feature | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sebastian Spiegel):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:5>

Django

unread,
Nov 9, 2016, 5:22:05 AM11/9/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Sebastian
| Spiegel
Type: New feature | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sebastian Spiegel):

I've pushed requested improvements to the
[https://github.com/django/django/pull/7522 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:6>

Django

unread,
Nov 17, 2016, 4:25:31 PM11/17/16
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: (none)
Type: New feature | Status: new

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sebastian Spiegel):

* status: assigned => new
* owner: Sebastian Spiegel => (none)


--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:7>

Django

unread,
Jan 6, 2017, 4:16:01 PM1/6/17
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: (none)
Type: New feature | Status: new
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:8>

Django

unread,
Jan 6, 2017, 9:25:25 PM1/6/17
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Tim
| Graham <timograham@…>
Type: New feature | Status: closed

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* owner: (none) => Tim Graham <timograham@…>
* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"8b734d2f990063df2988143dfb5f4449b60b9ca3" 8b734d2f]:
{{{
#!CommitTicketReference repository=""
revision="8b734d2f990063df2988143dfb5f4449b60b9ca3"
Fixed #27432 -- Made app_label arguments limit showmigrations --plan
output.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:9>

Django

unread,
Jan 9, 2017, 8:40:10 AM1/9/17
to django-...@googlegroups.com
#27432: showmigrations --plan should show migrations that would be applied for the
given app_labels
-------------------------------------+-------------------------------------
Reporter: Will Hardy | Owner: Tim
| Graham <timograham@…>
Type: New feature | Status: closed
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"9932e1bf52a8167af1bfce0db56e68ca60255814" 9932e1bf]:
{{{
#!CommitTicketReference repository=""
revision="9932e1bf52a8167af1bfce0db56e68ca60255814"
Fixed test isolation in a couple migrations tests.

Without this, tests from refs #27432 fail when running with --reverse.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27432#comment:10>

Reply all
Reply to author
Forward
0 new messages