Re: [Django] #31675: Add a warning about cyclic references in exceptions to the debug error view.
Django
view.
-------------------------------------+-------------------------------------
Reporter: Chris Jerdonek | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):
* owner: (none) => Hasan Ramezani
* status: new => assigned
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/13041 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31675#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
view.
-------------------------------------+-------------------------------------
Reporter: Chris Jerdonek | Owner: Hasan
Type: | Ramezani
Component: Error reporting | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a59de6e89e8dc1f3e71c9a5a5bbceb373ea5247e" a59de6e]:
{{{
#!CommitTicketReference repository=""
revision="a59de6e89e8dc1f3e71c9a5a5bbceb373ea5247e"
Fixed #31675 -- Added warning to ExceptionReporter when exception chain
has a cycle.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31675#comment:3>
Django
view.
-------------------------------------+-------------------------------------
Reporter: Chris Jerdonek | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Chris Jerdonek):
Will the PR that was committed cause the exception to display in the error
view in the list with the other exceptions? What I was suggesting is that
it would be helpful if, in the debug error view, the beginning of the
first repetition shows in the error view, with a description of what
exception was repeated. That way, the full exception chain is visible in
the error view.
--
Ticket URL: <https://code.djangoproject.com/ticket/31675#comment:4>
Django
view.
-------------------------------------+-------------------------------------
Reporter: Chris Jerdonek | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by felixxm):
Replying to [comment:4 Chris Jerdonek]:
> Will the PR that was committed cause the exception to display in the
error view in the list with the other exceptions? What I was suggesting is
that it would be helpful if, in the debug error view, the beginning of the
first repetition shows in the error view, with a description of what
exception was repeated. That way, the full exception chain is visible in
the error view.
No, a warning will appear only in the development server console. I think
it's enough since this is quite niche and I don't have an idea how to add
it to the debug view `frames` without a bigger refactoring. I'd be happy
to review a patch with improvements if you want to work on this.
--
Ticket URL: <https://code.djangoproject.com/ticket/31675#comment:5>
Django
view.
-------------------------------------+-------------------------------------
Reporter: Chris Jerdonek | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Chris Jerdonek):
Yeah, I could do it as an extension to the other two when I get around to
it. The approach I had in mind would use the existing template structure
so the repeated exception would display normally, just with a note of some
kind next to it. But it would need to come after fixing the other issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/31675#comment:6>