[Django] #23585: Fix misleading comment in CSRF middleware

[Django]

#23585: Fix misleading comment in CSRF middleware
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new
Cleanup/optimization | Version: master
Component: | Keywords:
contrib.csrf | Has patch: 0
Severity: Normal | Needs tests: 0
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
See https://groups.google.com/d/msg/django-
developers/24QVPMg7dsE/bx3qf2YLKyoJ

--
Ticket URL: <https://code.djangoproject.com/ticket/23585>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#23585: Fix misleading comment in CSRF middleware
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new
Cleanup/optimization | Version: master

Component: contrib.csrf | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by gregorth):

* has_patch: 0 => 1
* easy: 0 => 1

Comment:

here is pr: https://github.com/django/django/pull/3526

--
Ticket URL: <https://code.djangoproject.com/ticket/23585#comment:1>

[Django]

#23585: Fix misleading comment in CSRF middleware
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new
Cleanup/optimization | Version: master

Component: contrib.csrf | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by berkerpeksag):

* stage: Accepted => Ready for checkin

Comment:

[https://github.com/django/django/pull/3526 #3526] LGTM.

--
Ticket URL: <https://code.djangoproject.com/ticket/23585#comment:2>

[Django]

#23585: Fix misleading comment in CSRF middleware
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin

Type: | Status: closed
Cleanup/optimization | Version: master
Component: contrib.csrf | Resolution: fixed

Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Grzegorz Slusarek <grzegorz.slusarek@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"b4bb5cd0a31c6e9ebc2be9dff245f506940f9159"]:
{{{
#!CommitTicketReference repository=""
revision="b4bb5cd0a31c6e9ebc2be9dff245f506940f9159"
Fixed #23585 - Corrected internal comment.

Removed misleading comment and provide correct one, explaining
idea behind hardcoded CSRF template context processor.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23585#comment:3>

[Django]

#23585: Fix misleading comment in CSRF middleware
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin

Type: | Status: closed
Cleanup/optimization | Version: master
Component: contrib.csrf | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Marc Tamlyn <marc.tamlyn@…>):

In [changeset:"4024dd0c98d71647b2001f186a92242314c987b2"]:
{{{
#!CommitTicketReference repository=""
revision="4024dd0c98d71647b2001f186a92242314c987b2"
Merge pull request #3526 from gregorth/ticket_23585

Fixed #23585 - Corrected internal comment.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23585#comment:4>