[Django] #27615: Use native interval type on Oracle

29 views
Skip to first unread message

Django

unread,
Dec 19, 2016, 8:47:20 AM12/19/16
to django-...@googlegroups.com
#27615: Use native interval type on Oracle
-------------------------------------+-------------------------------------
Reporter: Tim | Owner: nobody
Graham |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: 1.10
layer (models, ORM) |
Severity: Normal | Keywords: oracle
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I think we can remove the `driver_supports_timedeltas` database feature
now that [https://bitbucket.org/anthony_tuininga/cx_oracle/issues/7 the
issue it's working around] is fixed in cx_oracle. See #24033 and the
commit: 5ca82e710e2f92b8c5114492205c8764918407d3.

--
Ticket URL: <https://code.djangoproject.com/ticket/27615>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 19, 2016, 8:55:12 AM12/19/16
to django-...@googlegroups.com
#27615: Use native interval type on Oracle
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:

Keywords: oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* Attachment "27615.diff" added.

Django

unread,
Dec 19, 2016, 8:56:38 AM12/19/16
to django-...@googlegroups.com
#27615: Use native interval type on Oracle
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

Attached is what I thought a patch might look like but `runtests.py
expressions` gives some "ORA-01867: the interval is invalid" errors, so
I'll leave this to someone interested in Oracle.

--
Ticket URL: <https://code.djangoproject.com/ticket/27615#comment:1>

Django

unread,
Dec 20, 2016, 1:01:43 AM12/20/16
to django-...@googlegroups.com
#27615: Use native interval type on Oracle
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: felixxm
Type: | Status: assigned

Cleanup/optimization |
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* status: new => assigned
* owner: nobody => felixxm


--
Ticket URL: <https://code.djangoproject.com/ticket/27615#comment:2>

Django

unread,
Dec 20, 2016, 3:38:49 PM12/20/16
to django-...@googlegroups.com
#27615: Use native interval type on Oracle
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7721 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27615#comment:3>

Django

unread,
Dec 28, 2016, 10:30:55 AM12/28/16
to django-...@googlegroups.com
#27615: Use native interval type on Oracle
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


Comment:

(pending #27649 to bump the minimum version of cx_Oracle)

--
Ticket URL: <https://code.djangoproject.com/ticket/27615#comment:4>

Django

unread,
Dec 29, 2016, 3:49:39 PM12/29/16
to django-...@googlegroups.com
#27615: Use native interval type on Oracle
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: felixxm
Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"7d14889aa3b0897a902034d1d11b8195463da32c" 7d14889]:
{{{
#!CommitTicketReference repository=""
revision="7d14889aa3b0897a902034d1d11b8195463da32c"
Fixed #27615 -- Used timedeltas as arguments to Oracle database driver.

Removed unused DatabaseFeatures.driver_supports_timedeltas workaround.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27615#comment:5>

Reply all
Reply to author
Forward
0 new messages