[Django] #18807: Inconsistency in the default views
Django
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
`django.views.defaults.permission_denied` will respond ``<h1>403
Forbidden</h1>`` if no ``403.html`` template is found. This behavior was
introduced to provide
[https://code.djangoproject.com/ticket/5515#comment:16 backwards
compatibility]. Generally speaking, it is a reasonable fallback.
I believe that `page_not_found` and `server_error` could benefit from a
similar fallback.
That would prevent 404s from turning into 500s when there's no 404.html
template. I know we want to encourage custom error pages, but in case a
developer skips them, a bare ``<h1>404 Not Found</h1>`` is less damaging
than a 500 with a backtrace or no content at all.
--
Ticket URL: <https://code.djangoproject.com/ticket/18807>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* stage: Unreviewed => Accepted
Comment:
#18948 demonstrates a bad side-effect of the current situation.
--
Ticket URL: <https://code.djangoproject.com/ticket/18807#comment:1>
Django
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/18807#comment:2>
Django
Reporter: aaugustin | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jezdez):
* stage: Accepted => Ready for checkin
Comment:
+1
--
Ticket URL: <https://code.djangoproject.com/ticket/18807#comment:3>
Django
Reporter: aaugustin | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Core (Other) | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"8bd7b598b6de1be1e3f72f3a1ee62803b1c02010"]:
{{{
#!CommitTicketReference repository=""
revision="8bd7b598b6de1be1e3f72f3a1ee62803b1c02010"
Fixed #18807 -- Made 404.html and 500.html optional
Thanks Aymeric Augustin for the report and Jannis Leidel for the
review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18807#comment:4>
Django
Reporter: Aymeric Augustin | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Jon Dufresne <jon.dufresne@…>):
In [changeset:"ff09add274aa4b53a8534463e9b3c9302bbcd661" ff09add2]:
{{{
#!CommitTicketReference repository=""
revision="ff09add274aa4b53a8534463e9b3c9302bbcd661"
Refs #18807 -- Removed unused exception handler from Client.request().
Unused since 8bd7b598b6de1be1e3f72f3a1ee62803b1c02010.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18807#comment:5>