[Django] #32962: Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql()

[Django]

#32962: Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql()
-------------------------------------+-------------------------------------
Reporter: Chris | Owner: Chris Jerdonek
Jerdonek |
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: dev
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently,
[https://github.com/django/django/blob/20226fcd461670334646f78a0c4d133e439b12b2/django/db/backends/base/schema.py#L209
BaseDatabaseSchemaEditor.column_sql()] builds up a `sql` string by
repeated concatenations with itself. I noticed this could be combined into
a single `' '.join(...)` if an iterator that yields `sql` parts is
factored out. This will eliminate the need to create temporary
intermediate strings and should improve readability.

--
Ticket URL: <https://code.djangoproject.com/ticket/32962>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#32962: Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql()
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted

Comment:

Tentatively accepted, so we can see what a patch looks like .

--
Ticket URL: <https://code.djangoproject.com/ticket/32962#comment:1>

[Django]

#32962: Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql()
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Chris Jerdonek):

* has_patch: 0 => 1

Comment:

PR: https://github.com/django/django/pull/14701

--
Ticket URL: <https://code.djangoproject.com/ticket/32962#comment:2>

[Django]

#32962: Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql()
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/32962#comment:3>

[Django]

#32962: Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql()
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek

Cleanup/optimization | Status: closed

Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"809c45ea3c45deedd45e66955ac68ca6bb418e03" 809c45e]:
{{{
#!CommitTicketReference repository=""
revision="809c45ea3c45deedd45e66955ac68ca6bb418e03"
Fixed #32962 -- Consolidated string concatenations in
BaseDatabaseSchemaEditor.column_sql().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32962#comment:4>

[Django]

#32962: Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql()
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: closed
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"fe074c96a343530beea50fbdd0803d3e7b739e8e" fe074c96]:
{{{
#!CommitTicketReference repository=""
revision="fe074c96a343530beea50fbdd0803d3e7b739e8e"
Refs #32962 -- Simplified NULL logic in
BaseDatabaseSchemaEditor._iter_column_sql().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32962#comment:5>