[Django] #23737: RequestContext docs should recommend the render shortcut more clearly

3 views
Skip to first unread message

Django

unread,
Oct 30, 2014, 5:01:03 PM10/30/14
to django-...@googlegroups.com
#23737: RequestContext docs should recommend the render shortcut more clearly
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
In https://docs.djangoproject.com/en/1.7/ref/templates/api/#subclassing-
context-requestcontext, there's a note that starts with "If you’re using
Django’s render_to_response() shortcut...".

It says "Alternatively, use the render() shortcut..." which is a rather
half-hearted recommendation.

Everyone uses render() all the time and it's just fine. I suggest
rewording that note or removing it.

--
Ticket URL: <https://code.djangoproject.com/ticket/23737>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 30, 2014, 6:34:10 PM10/30/14
to django-...@googlegroups.com
#23737: RequestContext docs should recommend the render shortcut more clearly
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: timgraham
Type: | Status: assigned
Cleanup/optimization | Version: 1.7
Component: Documentation | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: new => assigned
* owner: nobody => timgraham
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/23737#comment:1>

Django

unread,
Oct 30, 2014, 6:35:24 PM10/30/14
to django-...@googlegroups.com
#23737: RequestContext docs should recommend the render shortcut more clearly
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: timgraham
Type: | Status: closed
Cleanup/optimization | Version: 1.7
Component: Documentation | Resolution: fixed

Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"f85fcc75e3c19d9694012afe97947d7b516d5dfc"]:
{{{
#!CommitTicketReference repository=""
revision="f85fcc75e3c19d9694012afe97947d7b516d5dfc"
Fixed #23737 -- Recommended the render() shortcut more strongly.

Thanks Aymeric Augustin for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23737#comment:2>

Django

unread,
Oct 30, 2014, 6:35:30 PM10/30/14
to django-...@googlegroups.com
#23737: RequestContext docs should recommend the render shortcut more clearly
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: timgraham
Type: | Status: closed
Cleanup/optimization | Version: 1.7
Component: Documentation | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"de8825685491ed0e3078cdcef0f7fed7b08796cc"]:
{{{
#!CommitTicketReference repository=""
revision="de8825685491ed0e3078cdcef0f7fed7b08796cc"
[1.6.x] Fixed #23737 -- Recommended the render() shortcut more strongly.

Thanks Aymeric Augustin for the report.

Backport of f85fcc75e3 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23737#comment:3>

Django

unread,
Oct 30, 2014, 6:35:31 PM10/30/14
to django-...@googlegroups.com
#23737: RequestContext docs should recommend the render shortcut more clearly
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: timgraham
Type: | Status: closed
Cleanup/optimization | Version: 1.7
Component: Documentation | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"01119c9c0f17387d2046bbd700835d85330d5151"]:
{{{
#!CommitTicketReference repository=""
revision="01119c9c0f17387d2046bbd700835d85330d5151"
[1.7.x] Fixed #23737 -- Recommended the render() shortcut more strongly.

Thanks Aymeric Augustin for the report.

Backport of f85fcc75e3 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23737#comment:4>

Reply all
Reply to author
Forward
0 new messages