[Django] #26241: collectstatic's output of `skipping x (not modified)` isn't very clear
Django
-------------------------------------+--------------------
Reporter: kezabelle | Owner: nobody
Type: New feature | Status: new
Component: contrib.staticfiles | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+--------------------
Running `manage.py collectstatic` gives output like:
{{{
Skipping 'img/hello.jpg' (not modified)
}}}
Based on that message, it's unclear '''why''' the file was skipped. Is it
because the contents are the same? A hash collision of the filename,
content? Permissions? etc.
It's actually just because the timestamps match,
[https://github.com/django/django/blob/6ca163d7cc451fafd3015fa2ee735d5377fa3065/django/contrib/staticfiles/management/commands/collectstatic.py#L267
as far as I can tell] based on a quick
[https://github.com/django/django/search?q=%22not+modified%22+path%3Adjango%2Fcontrib&type=Code
search], which is absolutely fine, but I had to go to the implementation
to find out what constituted it being unmodified.
I'd like to suggest that the wording be improved/clarified. Perhaps just
something like `modified dates are the same` (I'm not tied to that wording
specifically!).
--
Ticket URL: <https://code.djangoproject.com/ticket/26241>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: kezabelle | Owner: AMaini503
Type: New feature | Status: assigned
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by AMaini503):
* owner: nobody => AMaini503
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26241#comment:1>
Django
Reporter: kezabelle | Owner: AMaini503
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by AMaini503):
* cc: AMaini503 (added)
* has_patch: 0 => 1
* type: New feature => Uncategorized
--
Ticket URL: <https://code.djangoproject.com/ticket/26241#comment:2>
Django
Reporter: kezabelle | Owner: AMaini503
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by AMaini503):
* Attachment "26241.diff" added.
Django
Reporter: kezabelle | Owner: AMaini503
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by AMaini503):
--> Modified the message as required for more clarity
Line 267 : collectstatic.py (old)
{{{
self.log("Skipping '%s' (not modified)" % path)
}}}
Line 267-269 : collecstatic.py (new)
{{{
# Message changed to convey the reason clearly as to why the file was
skipped beca
# Compares timestamps using --> http_date
self.log("Skipping '%s' (Dates of last modification are same)" % path)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26241#comment:3>
Django
Reporter: kezabelle | Owner: AMaini503
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by claudep):
As far as I'm concerned, `(not modified)` seems rather clear (the file has
not been modified since last run). I don't find the proposal better.
--
Ticket URL: <https://code.djangoproject.com/ticket/26241#comment:4>
Django
Reporter: kezabelle | Owner: AMaini503
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:
| worksforme
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* status: assigned => closed
* resolution: => worksforme
Comment:
I agree with Claude.
--
Ticket URL: <https://code.djangoproject.com/ticket/26241#comment:5>