[Django] #28780: Ability to customize INTERNAL_RESET_URL_TOKEN
Django
-----------------------------------------+------------------------
Reporter: Meiyer | Owner: nobody
Type: New feature | Status: new
Component: Uncategorized | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-----------------------------------------+------------------------
Since this parameter appears in the URL of the forgotten password reset
request (= part of the public interface of the website), it would be nice
if websites could customize the value.
--
Ticket URL: <https://code.djangoproject.com/ticket/28780>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
------------------------------+------------------------------------
Reporter: Meiyer | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Tim Graham):
* component: Uncategorized => contrib.auth
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:1>
Django
------------------------------+------------------------------------
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Tim G.):
* owner: nobody => Tim G.
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:2>
Django
------------------------------+------------------------------------
Reporter: Meiyer | Owner: Tim G.
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Tim G.):
How this parameter should be customizable? Settings?
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:3>
Django
------------------------------+------------------------------------
Reporter: Meiyer | Owner: Tim G.
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Tim Graham):
It could be a class attribute on the view.
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:4>
Django
------------------------------+------------------------------------
Reporter: Meiyer | Owner: Tim G.
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Meiyer):
I think the configuration that will allow the easiest customization is a
class attribute such as:
{{{
class PasswordResetConfirmView(PasswordContextMixin, FormView):
reset_token_placeholder = INTERNAL_RESET_URL_TOKEN
}}}
Then it can be used in urls.py with
{{{
url('<pattern>',
PasswordResetConfirmView.as_view(reset_token_placeholder='wachtwoord-
aanduiding'),
name='password_reset_confirm')
}}}
Because of the format limitations on the <token> parameter (two
alphanumeric strings separated by a hyphen), it will be useful to add
instructions to the documentation so that developers do not accidentally
break their password reset functionality.
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:5>
Django
------------------------------+------------------------------------
Reporter: Meiyer | Owner: Tim G.
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Tim G.):
PR is ready!
https://github.com/django/django/pull/9337
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:6>
Django
------------------------------+------------------------------------
Reporter: Meiyer | Owner: Tim G.
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Claude Paroz):
* has_patch: 0 => 1
* version: 1.11 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:7>
Django
------------------------------+------------------------------------
Reporter: Meiyer | Owner: Tim G.
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Tim Graham):
* needs_docs: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:8>
Django
------------------------------+------------------------------------
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 1
Changes (by Tim Graham):
* status: assigned => new
* owner: Tim G. => (none)
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:9>
Django
Reporter: Meiyer | Owner: xmeowmeowx
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 1
Changes (by xmeowmeowx):
* status: new => assigned
* owner: (none) => xmeowmeowx
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:10>
Django
------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 1
Comment (by robinh00d):
PR for this ticket has been submitted:
https://github.com/django/django/pull/11189
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:11>
Django
Reporter: Meiyer | Owner: robinh00d
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by robinh00d):
* needs_docs: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:12>
Django
------------------------------+-------------------------------------
Reporter: Meiyer | Owner: robinh00d
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+-------------------------------------
Changes (by felixxm):
* ui_ux: 1 => 0
* stage: Ready for checkin => Accepted
Comment:
Please do not mark your own PRs as "Ready for checkin" (see
[https://docs.djangoproject.com/en/2.2/internals/contributing/triaging-
tickets/#triage-workflow triage-workflow]).
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:13>
Django
------------------------------+-------------------------------------
Reporter: Meiyer | Owner: robinh00d
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
------------------------------+-------------------------------------
Comment (by robinh00d):
Replying to [comment:13 felixxm]:
> Please do not mark your own PRs as "Ready for checkin" (see
[https://docs.djangoproject.com/en/2.2/internals/contributing/triaging-
tickets/#triage-workflow triage-workflow]).
My apologies.
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:14>
Django
------------------------------+-------------------------------------
Reporter: Meiyer | Owner: robinh00d
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+-------------------------------------
Changes (by felixxm):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:15>
Django
------------------------------+-------------------------------------
Reporter: Meiyer | Owner: robinh00d
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
------------------------------+-------------------------------------
Changes (by robinh00d):
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:16>
Django
------------------------------+-------------------------------------
Reporter: Meiyer | Owner: robinh00d
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"58df8aa40fe88f753ba79e091a52f236246260b3" 58df8aa4]:
{{{
#!CommitTicketReference repository=""
revision="58df8aa40fe88f753ba79e091a52f236246260b3"
Fixed #28780 -- Allowed specyfing a token parameter displayed in password
reset URLs.
Co-authored-by: Tim Givois <tim.givo...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28780#comment:17>