[Django] #24244: Document contrib.admin.models.LogEntry
Django
-----------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: New feature | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-----------------------------------------+------------------------
It would be useful the document the fields and methods of this model.
A test also needs to be added for the `get_edited_object()` method as it's
currently not covered.
--
Ticket URL: <https://code.djangoproject.com/ticket/24244>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------+------------------------------------
Reporter: timgraham | Owner: nobody
Type: New feature | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Description changed by phalt:
Old description:
> It would be useful the document the fields and methods of this model.
>
> A test also needs to be added for the `get_edited_object()` method as
> it's currently not covered.
New description:
It would be useful to document the fields and methods of this model.
A test also needs to be added for the `get_edited_object()` method as it's
currently not covered.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:1>
Django
-------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by varun):
* owner: nobody => varun
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:2>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by EvilDMP):
* keywords: => afraid-to-commit
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:3>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by varun):
* Attachment "ticket_24244.diff" added.
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by varun):
* has_patch: 0 => 1
Comment:
PR: https://github.com/django/django/pull/4363
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:4>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by phalt):
PR has a test case but no documentation, do we want to separate these into
separate tickets?
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:5>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"74f8110e74927c231bfcd106fa28bf6e6dd034e6" 74f8110e]:
{{{
#!CommitTicketReference repository=""
revision="74f8110e74927c231bfcd106fa28bf6e6dd034e6"
Added test for LogEntry.get_edited_object(); refs #24244.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:6>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"8f5e8ab666bcc6e2dae9f147ac804f098fcb3f78" 8f5e8ab6]:
{{{
#!CommitTicketReference repository=""
revision="8f5e8ab666bcc6e2dae9f147ac804f098fcb3f78"
[1.8.x] Added test for LogEntry.get_edited_object(); refs #24244.
Backport of 74f8110e74927c231bfcd106fa28bf6e6dd034e6 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:7>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* has_patch: 1 => 0
Comment:
I committed the test, we can keep this ticket open for the documentation.
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:8>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner:
Component: Documentation | Version: master
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* owner: varun =>
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:9>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner:
Component: Documentation | Version: master
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by varun):
Where to add documentation ?
Can't find any admin related docs directory in ``docs/internals``
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:10>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner:
Component: Documentation | Version: master
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by timgraham):
Docs for `contrib.admin` are in `docs/ref/contrib/admin`.
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:11>
Django
----------------------------------+-------------------------------------
Reporter: timgraham | Owner: sholleman
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by sholleman):
* owner: => sholleman
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:12>
Django
----------------------------------+--------------------------------------
Reporter: timgraham | Owner: maestrofjp
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by maestrofjp):
* owner: sholleman => maestrofjp
Comment:
I have documentation in the works.
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:13>
Django
----------------------------------+-------------------------------------
Reporter: timgraham | Owner: sholleman
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by sholleman):
* owner: maestrofjp => sholleman
Comment:
Assigning back to me per maestrofjp.
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:14>
Django
----------------------------------+-------------------------------------
Reporter: timgraham | Owner: sholleman
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by maestrofjp):
Apologies for stealing the ticket. I should have refreshed the page after
letting it sit for ages. Let we were able to sit down to see that we were
both on the same page on how to do it.
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:15>
Django
----------------------------------+-------------------------------------
Reporter: timgraham | Owner: sholleman
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by alexmorozov):
@sholleman, won't you mind if I'll take this ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:16>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner:
Component: Documentation | Version: master
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by claudep):
* status: assigned => new
* owner: sholleman =>
Comment:
When no progress has been made after several months, feel free to take any
ticket!
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:17>
Django
----------------------------------+------------------------------------
Reporter: timgraham | Owner: varun
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by varun):
* owner: => varun
* status: new => assigned
Comment:
Patch almost ready. Creating PR by tomorrow.
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:18>
Django
----------------------------------+---------------------------------------
Reporter: timgraham | Owner: alexmorozov
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by alexmorozov):
* owner: varun => alexmorozov
Comment:
The pull request is at https://github.com/django/django/pull/5533 . Should
I specify it somewhere else?
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:19>
Django
----------------------------------+---------------------------------------
Reporter: timgraham | Owner: alexmorozov
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by alexmorozov):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:20>
Django
----------------------------------+---------------------------------------
Reporter: timgraham | Owner: alexmorozov
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"99c58c27d5a8e4a66230c413380508af223d12a8" 99c58c27]:
{{{
#!CommitTicketReference repository=""
revision="99c58c27d5a8e4a66230c413380508af223d12a8"
Fixed #24244 -- Documented contrib.admin.models.LogEntry
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:21>
Django
----------------------------------+---------------------------------------
Reporter: timgraham | Owner: alexmorozov
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"a31973c7c519234a07c1ec779fbc0bb424bcc702" a31973c7]:
{{{
#!CommitTicketReference repository=""
revision="a31973c7c519234a07c1ec779fbc0bb424bcc702"
[1.8.x] Fixed #24244 -- Documented contrib.admin.models.LogEntry
Backport of 99c58c27d5a8e4a66230c413380508af223d12a8 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:22>
Django
----------------------------------+---------------------------------------
Reporter: timgraham | Owner: alexmorozov
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"494046542c3cd47e518775290e1a366b6998183b" 4940465]:
{{{
#!CommitTicketReference repository=""
revision="494046542c3cd47e518775290e1a366b6998183b"
[1.9.x] Fixed #24244 -- Documented contrib.admin.models.LogEntry
Backport of 99c58c27d5a8e4a66230c413380508af223d12a8 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24244#comment:23>