[Django] #26882: Add test(s) for django.contrib.auth.views.logout_then_login
Django
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
This view is untested according to the coverage report. Tests likely go in
`tests/auth_tests/test_views.py`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26882>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner:
Type: | andersonresende
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by andersonresende):
* owner: nobody => andersonresende
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26882#comment:1>
Django
Reporter: timgraham | Owner:
Type: | andersonresende
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by andersonresende):
The warning is breaking my test :/
How to remove the warnings at test `RemovedInDjango21Warning: The logout()
view is superseded by the class-based LogoutView().`
--
Ticket URL: <https://code.djangoproject.com/ticket/26882#comment:2>
Django
Reporter: timgraham | Owner:
Type: | andersonresende
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by timgraham):
Replace `return logout(request, login_url, extra_context=extra_context)`
with `return LogoutView.as_view(login_url,
extra_context=extra_context)(request)`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26882#comment:3>
Django
Reporter: timgraham | Owner:
Type: | andersonresende
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by andersonresende):
Thx!
--
Ticket URL: <https://code.djangoproject.com/ticket/26882#comment:4>
Django
Reporter: timgraham | Owner:
Type: | andrewnester
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by andrewnester):
* owner: andersonresende => andrewnester
--
Ticket URL: <https://code.djangoproject.com/ticket/26882#comment:5>
Django
Reporter: timgraham | Owner:
Type: | andrewnester
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"dde6288fbe97c7053e67b613fec3366f3c298cf4" dde6288f]:
{{{
#!CommitTicketReference repository=""
revision="dde6288fbe97c7053e67b613fec3366f3c298cf4"
Fixed #26882 -- Added tests for auth.views.logout_then_login().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26882#comment:6>