Re: [Django] #9025: Nested Inline Support in Admin

197 views
Skip to first unread message

Django

unread,
May 23, 2011, 6:06:21 PM5/23/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
-------------------------------------+-------------------------------------
Changes (by skandocious):

* cc: skandocious (added)
* easy: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:54>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 9, 2011, 5:17:49 AM6/9/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by julien):

* ui_ux: => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:55>

Django

unread,
Jun 20, 2011, 11:11:32 AM6/20/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by anonymous):

Please, do that, guys.
Really needed for years.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:56>

Django

unread,
Jun 24, 2011, 11:43:13 AM6/24/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by KovaK):

This feature is a great improvement for the Django admin! When can we use
it in a stable Django release?

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:57>

Django

unread,
Jun 30, 2011, 11:26:10 AM6/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by Shawn Wall <shawnkwall@…>):

* cc: shawnkwall@… (added)


Comment:

This is a greatly needed feature in the admin.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:58>

Django

unread,
Jun 30, 2011, 12:24:10 PM6/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by RaceCondition):

* cc: eallik@… (removed)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:59>

Django

unread,
Aug 5, 2011, 6:10:16 PM8/5/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by gert):

* cc: gert314@… (added)


Comment:

+1 for this feature

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:60>

Django

unread,
Aug 6, 2011, 12:13:46 PM8/6/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by anonymous):

I just assumed I could do this! Then I tried and obviously it was a fail.
DEFINITELY a required feature. +1!

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:61>

Django

unread,
Aug 16, 2011, 8:25:38 PM8/16/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by anonymous):

+1 for this feature

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:62>

Django

unread,
Aug 30, 2011, 12:13:42 PM8/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by joeri@…):

* cc: joeri@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:63>

Django

unread,
Aug 30, 2011, 1:32:35 PM8/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by RaceCondition):

What do I have to do to stop receiving e-mails about updates to this
issue?

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:64>

Django

unread,
Aug 30, 2011, 1:42:18 PM8/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by tvon):

* cc: tomvons@… (removed)


Comment:

@ RaceCondition: removing yourself from the cc list seems to be the only
way. Bugzilla at least lets you control what notifications you get, but I
don't see that feature in this trace setup.

FWIW, from what I've heard this feature will not be implemented unless
someone submits a very serious patch, and I imagine you'd hear about that
through other channels if it were to happen.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:65>

Django

unread,
Aug 30, 2011, 1:44:06 PM8/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by RaceCondition):

@tomvons: I'm not in the CC list; I only get the option to add my e-mail
to the CC, otherwise I wouldn't be asking, would I...

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:66>

Django

unread,
Aug 30, 2011, 2:57:04 PM8/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by hha1@…):

* cc: hha1@… (removed)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:67>

Django

unread,
Aug 30, 2011, 3:09:55 PM8/30/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by danfairs):

* cc: dan.fairs@… (removed)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:68>

Django

unread,
Sep 28, 2011, 9:28:48 AM9/28/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by info.ksamuel@…):

+1 but obviously not as easy as it sounds. Really improves usability
though.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:69>

Django

unread,
Sep 28, 2011, 10:10:34 AM9/28/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by RaceCondition):

Why do I keep receiving e-mails about this ticket? I've removed myself
from CC. Please fix this issue, whoever is responsible for it.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:70>

Django

unread,
Sep 28, 2011, 10:14:15 AM9/28/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by jacob):

RaceCondition: sorry, it's a "feature" of Trac. Let me know which email
you're getting emails to and I'll take care of it. You can post a comment
here or email me at `jacob at jacobian dot org`.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:71>

Django

unread,
Sep 28, 2011, 10:14:43 AM9/28/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New | Status: new
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Comment (by aaugustin):

Replying to [comment:70 RaceCondition]:

> Why do I keep receiving e-mails about this ticket? I've removed myself
from CC. Please fix this issue, whoever is responsible for it.

See #16763.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:72>

Django

unread,
Sep 29, 2011, 12:19:04 AM9/29/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by danny.adair@…):

* cc: danny.adair@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:73>

Django

unread,
Oct 17, 2011, 9:46:39 AM10/17/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by RaceCondition):

it seems that "Remove from CC" doesn't work at all anymore. Is there a
solution to this? Effectively, code.djangoproject.com is sending out
unwanted emails.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:74>

Django

unread,
Nov 15, 2011, 2:52:01 PM11/15/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by palewire):

+1 for this feature.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:75>

Django

unread,
Nov 15, 2011, 10:17:20 PM11/15/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

Any solution ?(django 1.3.1)

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:76>

Django

unread,
Nov 18, 2011, 2:42:18 PM11/18/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by volrath):

* cc: daniel.barreto.n@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:77>

Django

unread,
Nov 21, 2011, 2:03:30 PM11/21/11
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

+1, it's really needed

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:78>

Django

unread,
Jan 4, 2012, 11:19:50 AM1/4/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

+1 Need it a lot ;)

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:79>

Django

unread,
Jan 9, 2012, 12:03:34 PM1/9/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

+1

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:80>

Django

unread,
Jan 17, 2012, 9:37:12 PM1/17/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

+1

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:81>

Django

unread,
Jan 20, 2012, 2:31:14 AM1/20/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

+1 for this feature

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:82>

Django

unread,
Jan 20, 2012, 8:49:43 AM1/20/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by kmike):

* cc: kmike84@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:83>

Django

unread,
Jan 23, 2012, 3:37:25 AM1/23/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by jokerejoker):

* cc: jokerejoker (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:84>

Django

unread,
Jan 23, 2012, 9:09:32 AM1/23/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

+1

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:85>

Django

unread,
Jan 23, 2012, 11:24:44 AM1/23/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by aaugustin):

If you're interested in this, don't add "+1", write the code.

When you write "+1", you're broadcasting "I'm too lazy to write this code,
do it for me" to all the people that could be interested in writing this
feature. That's quite a motivation killer. Just a heads up.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:86>

Django

unread,
Jan 23, 2012, 11:33:03 AM1/23/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by gonz):

* cc: gonz (removed)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:87>

Django

unread,
Feb 11, 2012, 12:47:10 PM2/11/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

Motivation killer.. Guys three years have passed.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:88>

Django

unread,
Feb 13, 2012, 6:53:44 AM2/13/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by shanx):

Dear anonymous, Django is open source remember. People don't owe you, even
if it has been ten years since something was reported in Trac. Do you want
Nested inline support? Step up to help out, pay a developer to build it,
be involved in some way to do something constructive....

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:89>

Django

unread,
Feb 13, 2012, 7:51:34 AM2/13/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by arj):

* cc: anders@… (removed)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:90>

Django

unread,
Mar 7, 2012, 11:34:20 PM3/7/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

I was looking for a solution to this as well

I've created a repository underwhich I started with a clone of 1.3.1

I initially applied the above patch and then modified it to extend the
functionality

as a result there are 2 new classes admin.NestedTabularInline and
admin.NestedStackedInline

I fixed the ability to use the add more button on the initial inline and
will be doing some work to fix the add more button for the nested inlines

I've not fully tested the stacked inlines but if someone wants to give
them a whirl I think they are good to go

[https://bitbucket.org/daveleblanc/django-nested-inlines]

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:91>

Django

unread,
Mar 15, 2012, 5:27:37 PM3/15/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by streeter):

* cc: streeter (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:92>

Django

unread,
Apr 7, 2012, 12:21:18 AM4/7/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

If someone is looking for a work around until this is committed, a simple
method for adding links between inlines and top-level admin pages, and top
level admin pages to related models, was posted Stack Overflow this week:
http://stackoverflow.com/a/10011307/500584

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:93>

Django

unread,
Apr 11, 2012, 4:24:39 PM4/11/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by anonymous):

I have losting the form validation, someone can help-me?

when i submit a invalid email
i have:
Caught KeyError while rendering: "Key 'processo' not found in Form"

but if a submit the same field by other user which not see the inline
nested, the form show the validation message.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:94>

Django

unread,
May 1, 2012, 11:29:29 AM5/1/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by carlospalol):

* cc: carlospalol (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:95>

Django

unread,
May 14, 2012, 6:20:13 AM5/14/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by kitsunde):

* cc: kitsunde@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:96>

Django

unread,
May 17, 2012, 8:54:52 AM5/17/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by info@…):

* cc: info@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:97>

Django

unread,
Jul 6, 2012, 11:58:35 PM7/6/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------------+-------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 1 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Li Meng <liokmkoil@…>):

* cc: liokmkoil@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:98>

Django

unread,
Jul 18, 2012, 5:48:50 PM7/18/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by aaugustin):

* stage: Design decision needed => Accepted


Comment:

Given the huge number of people interested in this feature, I'm brazenly
going to accept it.

It still needs a good patch with tests and docs. The tests should use the
Selenium support introduced in Django 1.4. Whoever writes such a patch
gets to make the remaining design decisions (such as max nesting depth,
etc.)

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:99>

Django

unread,
Aug 3, 2012, 8:46:47 AM8/3/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by jpedersen):

* cc: jpedersen (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:100>

Django

unread,
Aug 7, 2012, 12:19:41 PM8/7/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by frankoid):

* cc: frankoid (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:101>

Django

unread,
Aug 9, 2012, 2:47:14 PM8/9/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by dekkers):

* cc: jeroen@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:102>

Django

unread,
Sep 10, 2012, 8:31:32 PM9/10/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by simon29):

* cc: simon@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:103>

Django

unread,
Sep 14, 2012, 4:41:54 AM9/14/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by anonymous):

+1 for this feature

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:104>

Django

unread,
Sep 18, 2012, 3:57:04 AM9/18/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by anonymous):

Love to hear some good news on this.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:105>

Django

unread,
Sep 20, 2012, 5:11:27 PM9/20/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by pedrospdc@…):

+1 - those woul'd be REALLY nice.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:106>

Django

unread,
Sep 29, 2012, 2:21:49 PM9/29/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by anonymous):

+1 just looking for this function

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:107>

Django

unread,
Oct 7, 2012, 1:13:26 PM10/7/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned

Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Gargamel):

* status: new => assigned
* owner: nobody => Gargamel


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:108>

Django

unread,
Oct 7, 2012, 1:14:58 PM10/7/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

I have started working on this a few days ago. I have a sort off working
code that does whats needed, but lacks user friendliness. Currently
writing tests and fixing jquery stuff

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:109>

Django

unread,
Oct 8, 2012, 8:15:20 AM10/8/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

This is such great news! I am currently using a modified version of the
solution proposed in #comment:91, but the inline formsets and admin forms
code turned out to be quite complicated, and I can't wait to see a proper
solution.

Please post an update when you have a beta to test - I'd be eager to jump
on it.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:110>

Django

unread,
Oct 12, 2012, 4:32:42 AM10/12/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

I just finished fixing the jquery code, which took a bit longer than
expected. I'm now testing if the saving still works as expected, and then
I'll upload a div so people can maybe try it while i'm writing the rest of
the tests and the docs.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:111>

Django

unread,
Oct 16, 2012, 4:51:02 PM10/16/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by pztrick):

* cc: pztrick (added)


Comment:

I applied the above patch (nested_inlines_2.diff) to the latest master
branch today (v1.5alpha latest commit #bfcda7781a) and it appears to work
very well.

{{{
myApp.admin.py
--------
from django.contrib import admin
from myApp.models import Project, Parcel, Plot, Tree

class TreeInline(admin.TabularInline):
model = Tree
fields = ('genus','species','dbh')
extra = 0

class PlotInline(admin.StackedInline):
model = Plot
fields = ('name','shape_reported','area_reported')
inlines = [TreeInline, ]
extra = 0

class ParcelInline(admin.StackedInline):
model = Parcel
fields = ('name','area_reported')
inlines = [PlotInline, ]
extra = 0

class ProjectAdmin(admin.ModelAdmin):
fields = ('name','owner')
inlines = [ParcelInline, ]
}}}

The resulting screenshot is here: http://i46.tinypic.com/2qjzvkn.png

Implementation is as simple as adding an {{{inlines}}} definition to the
(inherited) TabularInline or StackedInline class (which is already
supported in the admin.ModelAdmin class). This is exactly what I had
originally tried to do before learning it was not supported, so I would
say its a very slick enhancement. Thank you Gargamel.

I will report back any new issues if I encounter them. (Changes did save
correctly for me.)

Next steps: docs and tests (?)

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:112>

Django

unread,
Oct 16, 2012, 9:42:22 PM10/16/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by RichardOfWard):

Tested also, works like a charm, nice work Gargamel, given the '+1'
comments here I suspect you'll have made a bunch of people happy.

{{{#!python
from django.contrib import admin

from .models import Band, Venue, Event, EventInstance, Booking

class BookingAdminInline(admin.TabularInline):
model = Booking

class EventInstanceAdminInline(admin.TabularInline):
model = EventInstance
inlines = (BookingAdminInline,)

class EventAdmin(admin.ModelAdmin):
inlines = (EventInstanceAdminInline,)

admin.site.register(Band, admin.ModelAdmin)
admin.site.register(Venue, admin.ModelAdmin)
admin.site.register(Event, EventAdmin)

}}}

One slight issue is that it becomes a bit difficult to tell what field you
are looking at when using a TabularInline - see the red arrows here:
http://oi48.tinypic.com/4gm5w2.jpg. The stacked version looks fine and the
fields are clearly labelled: http://i48.tinypic.com/rwnejt.png. Not sure
what the fix would be (other than simply not using TabularInline for
anything other than the innermost model), or even if it needs fixing.
Perhaps an extra header row after each nested model? Maybe only bother to
support StackedInline nesting? Probably a different bug for a different
day.

Otherwise, great stuff, intuitive to use - like pztrick I previously tried
adding an 'inlines' definition expecting it to work.

PS, I couldn't apply your patch (tried 'git am nested_inlines_2.diff',
'patch -p1 < nested_inlines_2.diff') without first poking it with a big
regex. What was I doing wrong?

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:113>

Django

unread,
Oct 16, 2012, 9:44:22 PM10/16/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by RichardOfWard):

* cc: RichardOfWard (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:114>

Django

unread,
Oct 18, 2012, 4:02:50 AM10/18/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by hejsan):

@Gargamel: Did you ever know that you're my hero?
(https://www.youtube.com/watch?v=Hu4gCIgM_SI)

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:115>

Django

unread,
Oct 18, 2012, 10:02:17 AM10/18/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by rugbyjock):

@Gargamel: Many thanks for this patch, it's exactly what I needed.
Unfortunately I think I've come across 2 bugs though...

(referring to the example in pztrick's post with Projects, Parcels, Plots
and Trees)

1) In the admin page when you have a Project with no Parcels, click on
"Add another Parcel" and you'll get a new Parcel to edit but it won't show
any of the "Add another Plot" options for the nested inlines.

2) If you have a Project with several Parcels and you click on "Add
another Parcel" you seem to get one Plot already made for each existing
Parcel that you have. If I make no more changes but click "Save" now, I
get the message "Parent object must be created when creating nested
inlines."

It is of course possible that my models are set up incorrectly but I think
they're ok - basically each nested inline has a foreign key to its
immediate parent. Using the tree example again, Tree has FK to Plot, Plot
has FK to Parcel, Parcel has FK to Project.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:116>

Django

unread,
Oct 19, 2012, 1:25:47 PM10/19/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

Hi guys
First of all, thanks for the feedback! I have been spending my time this
past week on the finishing touches. I fixed some more jquery bugs, wrote
all the test and wrote docs. I haven't read your feedback yet though, so
maybe some of the bugs are still in the code I uploaded. I will check this
this weekend and keep you up to date.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:117>

Django

unread,
Oct 19, 2012, 1:35:51 PM10/19/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

@RichardOfWard: Yes, I have noticed the problem with tabular inlines also.
I thought about adding the field headers again after each nested inline,
but this turned out to be very difficult. I would say if it bother people,
just use stacked inlines :D. I'm not sure why your patch didn't work. Did
you have any error messages or something? I'm not that proficient at
patches/diffs/git, so maybe I did something wrong...

@rugbyjock: I will look into these bugs. I just realize that I have done
very little testing with changing existing models, so thanks for pointing
this out!

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:118>

Django

unread,
Oct 20, 2012, 8:22:44 PM10/20/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by FunkyBob):

Just found this.. so glad someone took up the challenge...

Maybe I'm just a bit slow this morning, but I've never seen a patch in
that format, and I can't seem to figure out how to apply it.

Exactly what command line are you using the generate / apply this patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:119>

Django

unread,
Oct 21, 2012, 9:24:27 AM10/21/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

@FunkyBob: It shames me to tell you that I used some sort of git-gui
program to generate it. I have just reinstalled my linux system, so now I
can get on with learning the git syntax. Once I have fixed the last bugs
I'll post a command line git diff :)

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:120>

Django

unread,
Oct 22, 2012, 3:01:47 PM10/22/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

I fixed the second bug reported by rugbyjock. As of this patch, every
reported bug should have been fixed. I'll monitor this page until friday,
and if no new bug reports have come up, I'll make a pull request to the
master branch. Happy testing, I know I will :D

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:121>

Django

unread,
Oct 23, 2012, 8:14:31 AM10/23/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by kmike):

Replying to [comment:121 Gargamel]:


> I fixed the second bug reported by rugbyjock. As of this patch, every
reported bug should have been fixed. I'll monitor this page until friday,
and if no new bug reports have come up, I'll make a pull request to the
master branch. Happy testing, I know I will :D

Hey,
thanks for a work on this!

I didn't try the patch (only read it) and it seems there are some small
issues:

https://code.djangoproject.com/attachment/ticket/9025/nested_inlines_finished.diff#L98
- this is incorrect in Python3 (remove "u");
https://code.djangoproject.com/attachment/ticket/9025/nested_inlines_finished.diff#L519
- it seems 'var' is missed and this variable is defined as global;
https://code.djangoproject.com/attachment/ticket/9025/nested_inlines_finished.diff#L525
(and further) - the same applies to border_class variable.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:122>

Django

unread,
Oct 23, 2012, 8:52:40 AM10/23/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by rugbyjock):

@Gargamel - I've applied the latest patch but still see the bugs I
mentioned. I've attached a small project based on the trees and plots
discussed earlier which demonstrates the problem.

Problem 1: If you start it up and add a new project, you'll see a link for
"Add a New Parcel" but there is no way to add in the nested inlines. If I
adjust my admin script to "extra = 1" for all inlines, then this seems to
work.

Problem 2: If you set extra=1 and then added a project with a single
parcel, single plot and single tree, that looks like it worked. Click
"Save and Continue Editing" (any route into the editing repros the problem
fine) and then try to add a third (you already made one plus there is the
"extra=1" plot) plot to the first parcel. Notice how this plot now
contains two nested tree inlines which is wrong and also breaks if you try
to add data and save. The same problem occurs if you try to add a third
parcel.

Let me know if this doesn't make sense! Thanks again for your work on
this.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:123>

Django

unread,
Oct 23, 2012, 12:29:25 PM10/23/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by rugbyjock):

I forgot to mention - in problem 2 as described above, it only seems to go
wrong with the inlines have got extra=1 (or greater, I guess). With
extra=0 it works.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:124>

Django

unread,
Oct 24, 2012, 1:09:16 PM10/24/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

@rugbyjock: I was able to reproduce the first bug now, I forgot to set
extra=0. The problem is, I don't really see how this is fixable... The
root of the problem is that when extra is 0, the inline templates only
insert the 'empty-form', but these forms do not contain the nested forms,
because this would break all previous javascript code for inlines. I think
to fix this bug I would have to rewrite nearly all of my code and the
inline code in general... For this reason I will probably just disable the
option of putting 0 in the extra field when nested inlines are used. Maybe
one day I'll feel like rewriting the entire thing, but not now :).

The second bug was indeed fixed for the most, but I just uploaded the
wrong diff >.<

I'll do some more fixing and then I'll upload the file again.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:125>

Django

unread,
Oct 25, 2012, 4:18:19 AM10/25/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by rugbyjock):

@Gargamel - fair enough, I suspected it would be something like that. I'll
try working with a mixture of extra=1 at the higher level nesting and
extra=0 at the lower - perhaps this way I can sidestep the issue.

Looking forward to the new diff, I'll give it a test as soon as it's up.

Thanks again!

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:126>

Django

unread,
Oct 31, 2012, 10:00:06 AM10/31/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

Here's a list of problems with current code. (Some of these repeat the
bugs reported above, some are new).

1. If all extra attributes are set to 0, as mentioned above, saving an
inline results in "ManagementForm data is missing or has been tampered
with"
2. If the first-level inline (ParcelInline) has extra=1, and the others
have extra=0, I can add inlines and nested inlines, but saving or deleting
existing set of inlines without filling the extra inline fields fails with
this message: "Parent object must be created when creating nested inlines"
(for first-level inline modifications) or "ManagementForm data is missing
or has been tampered with" (for deeper levels).
3. For all extra=1 (or larger number), every time I try to save, all
extra fields have to be filled, otherwise the same errors appear. Deleting
inlines is impossible.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:127>

Django

unread,
Oct 31, 2012, 10:11:15 AM10/31/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

Commenting out three lines after "Here be dragons :(" (around line 1050 in
options.py) makes the "Parent object must be created when creating nested
inlines" go away.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:128>

Django

unread,
Oct 31, 2012, 10:42:18 AM10/31/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

Another bug: deleting an inline that contains nested inlines does not work
unless I first delete all the children.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:129>

Django

unread,
Oct 31, 2012, 10:54:33 AM10/31/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

Another bug: if you delete all inlines, you can't add any inlines after
that - you get a "ManagementForm data is missing or has been tampered
with" error.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:130>

Django

unread,
Nov 1, 2012, 9:22:53 AM11/1/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by anonymous):

Damn, I just typed a massive post about my plans with this feature, but
then my firefox restarted for some reason and I lost it all :(. I'll just
do a tl;dr because I don't really feel like typing it all again. Maybe
later.

In short, I'm going to start from scratch with a design based on nested
inlines from the ground up. This means I will need to rewrite most of the
inline jquery code, so I don't expect this to be done in a week or so.
I'll try to post weekly updates of my progress.

Thanks to everyone for the bug reports, though I will not fix them, they
are usefull for test ideas in the future!

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:131>

Django

unread,
Nov 1, 2012, 2:34:38 PM11/1/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by alexkoshelev):

* cc: alexkoshelev (removed)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:132>

Django

unread,
Nov 1, 2012, 3:27:45 PM11/1/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by bjola):

* cc: bjola (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:133>

Django

unread,
Nov 3, 2012, 12:23:08 AM11/3/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

Found another bug/TODO item: helpers.AdminErrorList needs to be updated,
so that it iterates over nested formsets. Otherwise, a form validation
error in a nested formset does not result in a general message above the
admin form. This can be a problem if the form is long or uses custom
styles that hide some of the fields, such as tabbed interface.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:134>

Django

unread,
Nov 12, 2012, 3:23:38 PM11/12/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by anonymous):

@bjola: Thanks, I did not think of that!

Just a short update, I haven't made much progress yet. Most of my free
time is crawling into this now, but I am actually incredibly stuck on
finding a proper design to start with. The problem is just that when an
inline has extra=0, it's formset does not contain any forms, so the
nesting stops there. I somehow need to decouple the recursive inline-
nesting function from the formsets, but this proves to be quite
complicated...

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:135>

Django

unread,
Nov 12, 2012, 6:35:02 PM11/12/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

Not sure if this is the best way, but it's ''a'' way - I hacked my admin
templates to include a sample form for every inline, including nested
inlines. The sample form input ID's all have a '-sample' suffix. If the JS
code that handles "add" link can find an existing formset, everything goes
normally. Otherwise, it takes the sample one, clones it, strips away the
'-sample', etc.

I only needed this for a specific project, so I just hard-coded the sample
form into admin template for that particular model. But to make it
generic, I'm guessing one would need to supply a "sample formset" along
with the real one from the server side.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:136>

Django

unread,
Nov 15, 2012, 7:45:57 PM11/15/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by bjola):

Another bug: in contrib/admin/static/js/inlines.js, the lines:
{{{
// Update Form Properties
template.find('#id_' + formset_prefix + '-TOTAL_FORMS').val(1);
update_props(template, normalized_formset_prefix, formset_prefix);
}}}

should be
{{{
// Update Form Properties
update_props(template, normalized_formset_prefix, formset_prefix);
template.find('#id_' + formset_prefix + '-TOTAL_FORMS').val(1);
template.find('#id_' + formset_prefix + '-INITIAL_FORMS').val(0);
}}}

Because the TOTAL_FORMS and INITIAL_FORMS inputs do not have the right IDs
until update_props is run. And INITIAL_FORMS needs to be 0, otherwise the
server-side validation tries to save non-existing nested forms.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:137>

Django

unread,
Nov 19, 2012, 1:46:28 PM11/19/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner: Gargamel
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Gargamel):

@bjola, thanks again, bugs are always helpfull to learn :). About your
'hack', I have thought about this too, but it makes the html so incredibly
cluttered and very hard to handle, not to mention that jquery performance
would nosedive when models get more complicated with such a massive DOM.
So thats why I am now, as you said, trying to make the server side
generate 1 sample formset for every inline used.

Well, I'm glad to announce I have made some progress. It's not the most
pythonic code I've ever written, but its ok and it seems to work
perfectly. I still need to implement the whole error checking, templates
and jquery shebang, so it won't be done for a while, but suggestions are
always welcome. If anyone would like a diff to check my approach and maybe
offer some suggestions, just ask :)

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:138>

Django

unread,
Dec 5, 2012, 11:55:56 AM12/5/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new

Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Gargamel):

* status: assigned => new
* owner: Gargamel =>


Comment:

Well, I'm going to unassign this, because I don't feel I'm progressing
fast enough... I'm still gonna work on it in my spare time, but with a
different approach. I just can't wrap my head around the patterns used for
the InlineFormSet classes and such, and this is definitely holding me
down.
On the other hand, maybe my current approach is just completely wrong...
I'm just gonna take my time to really understand the codebase behind the
whole inlines and then try again until I succeed.
Well, if anybody really wants nested inlines, the supplied patch works ok
I guess, except for some special cases so that will have to do for now.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:139>

Django

unread,
Dec 17, 2012, 6:55:48 AM12/17/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by ckesselh):

* cc: ckesselh (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:140>

Django

unread,
Dec 18, 2012, 1:54:40 PM12/18/12
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by bullfish):

* cc: bullfish (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:141>

Django

unread,
Jan 27, 2013, 8:25:47 PM1/27/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by bignose):

* needs_tests: 1 => 0


Comment:

Th current version of the patch has documentation and tests. Good!

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:142>

Django

unread,
Jan 30, 2013, 8:15:42 AM1/30/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Stefan Klug <klug.stefan@…>):

* cc: klug.stefan@… (added)


Comment:

Hi, could anyone with better knowledge summarize the status of this
feature? I'd like to give it a try and potentially add some fixes. To my
knowledge the status is as follows:
* There is a patch (nested_inlines_finished.diff) by Gargamel which has
docs and tests but still contains some bugs described in #comment:127,
#comment:134 bjola did some work on this. @bjola: Is there any public
version of this work available?
* The bugs seemed so severe that Gargamel restarted from scratch, did some
progress but hasn't got enough spare time to push it further. I'd love to
see the status of this work as it seems a waste of time to debug the old
patch when Gargamel decided to abandon it.
@Gragamel: Could you post a patch or link a git repository where the
status of your new work can be seen? - Or did you dump the whole thing
(#comment:140 seems like that)

It would be a lot easier to help, if there was a central place with the
current state. Maybe one of the core devs could put up a git branch for
this feature?

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:143>

Django

unread,
Jan 31, 2013, 9:22:32 AM1/31/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by stefanklug):

After several hours of stepping through the django code, I came up with a
new version. It lives in the nested-inline-support-1.5.x of my django
fork: https://github.com/stefanklug/django/tree/nested-inline-
support-1.5.x

It is based on the current django 1.5.x branch. I applied the proposed
patch (nested_inlines_finished.diff) and did some further improvements:
All bugs mentioned in #comment:127 should be fixed. I had to add some
things to django.forms. These have to be discussed with a core dev.
The problem mentioned in #comment:135 is not yet fixed. This needs some
more thinking and some bigger changes, but shouldn't be a show stopper.
The BugRepo attached to this task works for me out of the box now.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:144>

Django

unread,
Feb 8, 2013, 11:09:08 AM2/8/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by ZmjbS):

* cc: ZmjbS (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:145>

Django

unread,
Feb 20, 2013, 10:48:02 AM2/20/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Daniel <dablak@…>):

* cc: dablak@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:146>

Django

unread,
Feb 20, 2013, 6:22:14 PM2/20/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by jonathan.barratt@…):

* cc: jonathan.barratt@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:147>

Django

unread,
Feb 21, 2013, 4:22:45 PM2/21/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by Alain Trinh <i.am@…>):

Hey everyone, I just aped Stefan Klug's code and produced an easy to
install package that provides nested inline support in Django >=1.4. I
welcome everyone to issue bug reports and pull requests on the repo:
https://github.com/Soaa-/django-nested-inlines

Please test installation and functionality as this is my first ever
package.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:148>

Django

unread,
Feb 21, 2013, 4:28:45 PM2/21/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Alain Trinh <i.am@…>):

* cc: i.am@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:149>

Django

unread,
Feb 25, 2013, 9:08:43 AM2/25/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by jowett.zhang):

Hello, Dear guys, I'm a new comer on django and encounter this inline
requirement. But still don't know how to install this patch, even after i
read all this comments. Can someone help me on it?

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:150>

Django

unread,
Feb 25, 2013, 10:44:32 AM2/25/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by pztrick):

Jowett, I recommend using Alain Trinh's package from #comment:148 -
https://github.com/Soaa-/django-nested-inlines (works for me)

Installation is as easy as: {{{pip install -e git+git://github.com/Soaa
-/django-nested-inlines.git#egg=django-nested-inlines}}}

There are more instructions in the github README for actually using the
module in your code.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:151>

Django

unread,
Feb 27, 2013, 8:43:11 AM2/27/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by dokterbob):

If we can easily do this using an externally maintained module and we want
to limit the code maintenance pressure on core devs, shouldn't we just
mark this issue as a 'wontfix'?

@aaugustin: What's your take on this, having accepted the ticket some
several months ago?

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:152>

Django

unread,
Feb 27, 2013, 9:01:23 AM2/27/13
to django-...@googlegroups.com
#9025: Nested Inline Support in Admin
-------------------------------+------------------------------------
Reporter: pixelcort | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by aaugustin):

It's fine to keep it as "accepted".

After 150 comments and dozen of patches, I don't think uploading one more
patch here will be noticed. If someone really wants this to happen, take
it to django-developers with a solid proposal.

By "solid proposal" I mean something like https://groups.google.com/d/msg
/django-developers/zwQju7hbG78/EV0tky1oMUYJ.

--
Ticket URL: <https://code.djangoproject.com/ticket/9025#comment:153>

It is loading more messages.
0 new messages