[Django] #19361: Link to object in message after creating/updating object in django admin
Django
-------------------------+-------------------------------------------------
Reporter: | Owner: nobody
anonymous | Status: new
Type: New | Version: 1.5-alpha-1
feature | Keywords: admin, messages, update_object,
Component: | create_object
contrib.admin | Has patch: 0
Severity: Normal | UI/UX: 0
Triage Stage: |
Unreviewed |
Easy pickings: 0 |
-------------------------+-------------------------------------------------
When you have a lot of objects listed in the admin, like items in a shop,
it is hard to find the object after you created/updated it. Obviously
there is an option "Save and continue editing" but in practice it happens
that after saving users suddenly realize there are not finished yet.
For example: If i clicked an item in app shop in the middle of the items
list, or in search results, I have to find it manually or by using the
search-on-page in the browser after saving the object. This problem can
easily be solved by adding a link in the message to the object, which
appears on top of the page after creating/updating. The title is already
in there, so it should not be that hard to resolve the url to the admin
page.
Example message: The item "Vintage Star Trek action figure" was changed
successfully.
New message: The item "__Vintage Star Trek action figure__" was changed
successfully.
Of course there are some cases, like when the change page ({{ app_label
}}_{{ model_name }}_change) is not used or overriden or whatever the coder
did to break the url structure and not using the correct names anymore.
--
Ticket URL: <https://code.djangoproject.com/ticket/19361>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: anonymous | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version:
Severity: Normal | 1.5-alpha-1
Keywords: admin, messages, | Resolution:
update_object, create_object | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by BozeWolf):
* cc: BozeWolf (added)
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
I forgot to login when posting this ticket. But i'm the owner. I added
myself to Cc.
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:1>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version:
Severity: Normal | 1.5-alpha-1
Keywords: admin, messages, | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bak1an):
* owner: nobody => bak1an
* status: new => assigned
* stage: Unreviewed => Accepted
Comment:
this will be usable
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:2>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by bak1an):
* version: 1.5-alpha-1 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:3>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by bak1an):
some status update:
* a branch with quick implementation (not finished yet)
[https://github.com/bak1an/django/compare/admin-messages admin-messages]
* this is kind of depends on #19387. when (if) it will be merged into
master we will be able to remove next hunk from diff (i don't like this
{{{safe}}} filter there):
{{{
--- a/django/contrib/admin/templates/admin/base.html
+++ b/django/contrib/admin/templates/admin/base.html
@@ -53,7 +53,7 @@
{% block messages %}
{% if messages %}
<ul class="messagelist">{% for message in messages %}
- <li{% if message.tags %} class="{{ message.tags }}"{% endif
%}>{{ message }}</li>
+ <li{% if message.tags %} class="{{ message.tags }}"{% endif
%}>{{ message|safe }}</li>
{% endfor %}</ul>
{% endif %}
{% endblock messages %}
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:4>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by BozeWolf):
Good to see progress. Will test it as soon as it's finished.
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:5>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by bak1an):
[https://github.com/django/django/pull/786 pull request]
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:6>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object | Needs documentation: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:7>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object | Needs documentation: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by bak1an):
* needs_better_patch: 0 => 1
Comment:
needs rebase
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:8>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object | Needs documentation: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by bak1an):
* has_patch: 1 => 0
Comment:
patch is too old, will try to update it
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:9>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bak1an):
* needs_better_patch: 1 => 0
* has_patch: 0 => 1
Comment:
it's been a long time, but here goes rebased pull request
https://github.com/django/django/pull/5244
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:10>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
I left comments for improvement on the pull request.
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:11>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:12>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bak1an):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:13>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bak1an):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:14>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bak1an):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:15>
Django
Reporter: anonymous | Owner: bak1an
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bak1an):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:16>
Django
Reporter: anonymous | Owner: bak1an
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: admin, messages, | Triage Stage: Accepted
update_object, create_object |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"80bcbecd4a394f67c1679b077ba79a797c4a57d7" 80bcbecd]:
{{{
#!CommitTicketReference repository=""
revision="80bcbecd4a394f67c1679b077ba79a797c4a57d7"
Fixed #19361 -- Added link to object's change form in admin's post-save
message.
Thanks Roel Kramer for tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/19361#comment:17>