[Django] #29766: Add admonition after submit a new commit
Django
------------------------------------------------+------------------------
Reporter: Windson yang | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I used to use `git rebase -i ` to amend the local commits and `git push
-f` once the maintainer asks me to update a patch. But that makes the
maintainers hard to review my code. Instead, I should just create a new
commit. Then let the maintainers to squash when they merge the diff. I'm
not sure this is my own problem or we should mention the workflow at
[https://docs.djangoproject.com/en/2.1/intro/contributing/#pushing-the-
commit-and-making-a-pull-request]
--
Ticket URL: <https://code.djangoproject.com/ticket/29766>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Windson yang | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
Hi Windson.
> ... hard to review my code. Instead, I should just create a new
commit...
Sometimes, yes. Often, no. The commit history isn't that helpful for most
patches. For some it is (especially if well crafted).
Whether to push a single commit or steps is a question of judgement. I'm
not sure what we'd add to the docs about that.
I guess I'm inclined to think the advice towards a single commit if the
best baseline. (Allowing individuals to judge otherwise.)
Do you have a specific change in mind?
--
Ticket URL: <https://code.djangoproject.com/ticket/29766#comment:1>
Django
Reporter: Windson yang | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 2.1
Severity: Normal | Resolution:
| worksforme
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* status: new => closed
* resolution: => worksforme
Comment:
The suggested workflow is described in more detail at
[https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/working-with-git/ Working with Git and GitHub]. As Carlton said, if you
have a specific change in mind, feel free to send a pull request.
--
Ticket URL: <https://code.djangoproject.com/ticket/29766#comment:2>