[Django] #21671: model_inheritance_same_model_name tests fail in isolation
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: Database | Version: 1.6
layer (models, ORM) | Keywords:
Severity: Normal | Has patch: 0
Triage Stage: | Needs tests: 0
Unreviewed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
{{{
tests % ./runtests.py model_inheritance_same_model_name
--settings=test_sqlite
Creating test database for alias 'default'...
Traceback (most recent call last):
File "./runtests.py", line 359, in <module>
options.failfast, args)
File "./runtests.py", line 200, in django_tests
test_labels or get_installed(), extra_tests=extra_tests)
File "/Users/myk/Documents/dev/django/django/test/runner.py", line 145,
in run_tests
old_config = self.setup_databases()
File "/Users/myk/Documents/dev/django/django/test/runner.py", line 107,
in setup_databases
return setup_databases(self.verbosity, self.interactive, **kwargs)
File "/Users/myk/Documents/dev/django/django/test/runner.py", line 279,
in setup_databases
verbosity, autoclobber=not interactive)
File "/Users/myk/Documents/dev/django/django/db/backends/creation.py",
line 339, in create_test_db
load_initial_data=False)
File
"/Users/myk/Documents/dev/django/django/core/management/__init__.py", line
159, in call_command
return klass.execute(*args, **defaults)
File "/Users/myk/Documents/dev/django/django/core/management/base.py",
line 284, in execute
self.validate()
File "/Users/myk/Documents/dev/django/django/core/management/base.py",
line 314, in validate
raise CommandError("One or more models did not validate:\n%s" %
error_text)
django.core.management.base.CommandError: One or more models did not
validate:
model_inheritance_same_model_name.copy: 'title' has a relation with model
<class 'model_inheritance.models.Title'>, which has either not been
installed or is abstract.
}}}
This problem exists both in master and stable/1.6.x (I didn't check
earlier versions).
The tests pass only when they're run in combination with the
model_inheritance tests.
{{{
tests % ./runtests.py model_inheritance_same_model_name model_inheritance
--settings=test_sqlite
Creating test database for alias 'default'...
Creating test database for alias 'other'...
........
----------------------------------------------------------------------
Ran 8 tests in 0.053s
OK
Destroying test database for alias 'default'...
Destroying test database for alias 'other'...
}}}
It would be useful to fix this because it can create false positives when
using the --bisect or --pair options of the test suite.
--
Ticket URL: <https://code.djangoproject.com/ticket/21671>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/21671#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by claudep):
Would it be acceptable that those tests are skipped when
`model_inheritance` app is not tested/installed (as of attached patch)?
--
Ticket URL: <https://code.djangoproject.com/ticket/21671#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by aaugustin):
That's a reasonable solution.
We have an API to tell if an application is installed in Django 1.7:
https://docs.djangoproject.com/en/dev/ref/applications/#django.apps.apps.is_installed
--
Ticket URL: <https://code.djangoproject.com/ticket/21671#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: anubhav9042@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/21671#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Component: Database layer | Version: 1.6
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
Fixed in #22402 (the `model_inheritance_same_model_name` app was
consolidated into `model_inheritance`).
--
Ticket URL: <https://code.djangoproject.com/ticket/21671#comment:5>