[Django] #32374: Migrations are marked applied even if deferred SQL fails to execute
Django
------------------------------------------+--------------------------
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: assigned
Component: Migrations | Version: 2.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+--------------------------
The changes introduced in c86a3d80a25acd1887319198ca21a84c451014ad to
address #29721 fail to account for the possibility of the schema editor
accumulation of deferred SQL which is run at `SchemaEditor.__exit__` time.
--
Ticket URL: <https://code.djangoproject.com/ticket/32374>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: assigned
Component: Migrations | Version: 2.2
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Simon Charette):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32374#comment:1>
Django
Reporter: Simon Charette | Owner: Simon Charette
Type: Bug | Status: assigned
Component: Migrations | Version: 2.2
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: nobody => Simon Charette
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/32374#comment:2>
Django
Reporter: Simon Charette | Owner: Simon Charette
Component: Migrations | Version: 2.2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"0c42cdf0d2422f4c080e93594d5d15381d6e955e" 0c42cdf0]:
{{{
#!CommitTicketReference repository=""
revision="0c42cdf0d2422f4c080e93594d5d15381d6e955e"
Fixed #32374 -- Stopped recording migration application before deferred
SQL.
Migrations cannot be recorded in the same transaction as its associated
DDL operations when some of it is deferred until the schema editor
context exits.
Regression in c86a3d80a25acd1887319198ca21a84c451014ad.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32374#comment:3>
Django
Reporter: Simon Charette | Owner: Simon Charette
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"6520ce5251e7d63d08bf965e5ca00e508f8a8613" 6520ce5]:
{{{
#!CommitTicketReference repository=""
revision="6520ce5251e7d63d08bf965e5ca00e508f8a8613"
[3.2.x] Fixed #32374 -- Stopped recording migration application before
deferred SQL.
Migrations cannot be recorded in the same transaction as its associated
DDL operations when some of it is deferred until the schema editor
context exits.
Regression in c86a3d80a25acd1887319198ca21a84c451014ad.
Backport of 0c42cdf0d2422f4c080e93594d5d15381d6e955e from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32374#comment:4>