[Django] #28711: unordered_list template filter does not work with lazy translations
Django
-------------------------------------------+------------------------
Reporter: Jonas Haag | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
I would expect that the following assertion holds true:
{{
from django.utils.translation import ugettext_lazy as _
from django.template.defaultfilters import unordered_list
assert unordered_list(['', _('lazy')]) == unordered_list(['', 'lazy']))
}}
I.e., `unordered_list` handles lazy translations as if they were strings.
This used to work in Django < 1.8, more specifically before the patch to
this ticket: https://code.djangoproject.com/ticket/23260
This bug exists in all versions 1.8–master.
Pull request follows.
--
Ticket URL: <https://code.djangoproject.com/ticket/28711>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Jonas Haag | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by Jonas Haag:
Old description:
> I would expect that the following assertion holds true:
>
> {{
> from django.utils.translation import ugettext_lazy as _
> from django.template.defaultfilters import unordered_list
>
> assert unordered_list(['', _('lazy')]) == unordered_list(['', 'lazy']))
> }}
>
> I.e., `unordered_list` handles lazy translations as if they were strings.
>
> This used to work in Django < 1.8, more specifically before the patch to
> this ticket: https://code.djangoproject.com/ticket/23260
>
> This bug exists in all versions 1.8–master.
>
> Pull request follows.
New description:
I would expect that the following assertion holds true:
{{{
from django.utils.translation import ugettext_lazy as _
from django.template.defaultfilters import unordered_list
assert unordered_list(['', _('lazy')]) == unordered_list(['', 'lazy']))
}}}
I.e., `unordered_list` handles lazy translations as if they were strings.
This used to work in Django < 1.8, more specifically before the patch to
this ticket: https://code.djangoproject.com/ticket/23260
This bug exists in all versions 1.8–master.
Pull request follows.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:1>
Django
Reporter: Jonas Haag | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Jonas Haag):
PR: https://github.com/django/django/pull/9240
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:2>
Django
Reporter: Jonas Haag | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:3>
Django
Reporter: Jonas Haag | Owner: nobody
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"d997ab776477dd9ecb158229b2622c7f1ed93dfb" d997ab7]:
{{{
#!CommitTicketReference repository=""
revision="d997ab776477dd9ecb158229b2622c7f1ed93dfb"
Fixed #28711 -- Fixed unordered_list template filter with lazy
translations.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:4>
Django
Reporter: Jonas Haag | Owner: nobody
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"a831e4bad0e5f616680955dfd63a38fa49d8086b" a831e4b]:
{{{
#!CommitTicketReference repository=""
revision="a831e4bad0e5f616680955dfd63a38fa49d8086b"
[2.0.x] Fixed #28711 -- Fixed unordered_list template filter with lazy
translations.
Backport of d997ab776477dd9ecb158229b2622c7f1ed93dfb from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:5>
Django
Reporter: Jonas Haag | Owner: nobody
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"1399f8ae77f78c5dc8461fe1604d2a58219aa298" 1399f8a]:
{{{
#!CommitTicketReference repository=""
revision="1399f8ae77f78c5dc8461fe1604d2a58219aa298"
Refs #28711 -- Replaced ugettext_lazy() with gettext_lazy() in a test.
As per c651331b34b7c3841c126959e6e52879bc6f0834.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:6>
Django
Reporter: Jonas Haag | Owner: nobody
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Jonas Haag):
Will this be backported to Django 1.11? IIUC it still receives bug fixes
until end of this year.
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:7>
Django
Reporter: Jonas Haag | Owner: nobody
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham):
Fixes for regressions are generally backported to the latest stable
release but as this is such a long standing regression, it doesn't seem
critical. I'm wary of introducing a different regression this late in
1.11.x's bug fix period and the patch does not backport cleanly to 1.11
where Python 2 compatibility is required.
--
Ticket URL: <https://code.djangoproject.com/ticket/28711#comment:8>