[Django] #32829: clearsessions help text is incorrect

2 views
Skip to first unread message

Django

unread,
Jun 8, 2021, 6:15:36 PM6/8/21
to django-...@googlegroups.com
#32829: clearsessions help text is incorrect
------------------------------------------------+------------------------
Reporter: Baptiste Mispelon | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.sessions | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
The `--help` text for the `clearsessions` command states:

> Can be run as a cronjob or directly to clean out expired sessions (only
with the database backend at the moment).


But looking at the backends, several of them (not just the `database` one)
implement the `clear_expired()` method used by that command.

I would suggest the following replacement:

> Can be run as a cronjob or directly to clean out expired sessions when
the backend supports it.

--
Ticket URL: <https://code.djangoproject.com/ticket/32829>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 9, 2021, 1:16:44 AM6/9/21
to django-...@googlegroups.com
#32829: clearsessions help text is incorrect
--------------------------------------+------------------------------------

Reporter: Baptiste Mispelon | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.sessions | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


Comment:

Good catch, it's obsolete since 5fec97b9df6ea075483276de159e522a29437773.

--
Ticket URL: <https://code.djangoproject.com/ticket/32829#comment:1>

Django

unread,
Jun 9, 2021, 5:45:31 AM6/9/21
to django-...@googlegroups.com
#32829: clearsessions help text is incorrect
-------------------------------------+-------------------------------------
Reporter: Baptiste Mispelon | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: contrib.sessions | Version: 3.2

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Hasan Ramezani):

* owner: nobody => Hasan Ramezani
* status: new => assigned
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/14506 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32829#comment:2>

Django

unread,
Jun 9, 2021, 6:09:21 AM6/9/21
to django-...@googlegroups.com
#32829: clearsessions help text is incorrect
-------------------------------------+-------------------------------------
Reporter: Baptiste Mispelon | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: contrib.sessions | Version: 3.2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"ed3af3ff4b3cfb72de598f1b39a1028ba3826efb" ed3af3f]:
{{{
#!CommitTicketReference repository=""
revision="ed3af3ff4b3cfb72de598f1b39a1028ba3826efb"
Fixed #32829 -- Updated help text for clearsessions management command.

Obsolete since 5fec97b9df6ea075483276de159e522a29437773.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32829#comment:3>

Django

unread,
Jun 9, 2021, 9:09:26 AM6/9/21
to django-...@googlegroups.com
#32829: clearsessions help text is incorrect
-------------------------------------+-------------------------------------
Reporter: Baptiste Mispelon | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: contrib.sessions | Version: 3.2

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Baptiste Mispelon):

Thanks everyone!

--
Ticket URL: <https://code.djangoproject.com/ticket/32829#comment:4>

Reply all
Reply to author
Forward
0 new messages