[Django] #26135: The migrate command with `--run-syncdb` crash if an application's migrations are disabled by setting MODULE_MIGRATIONS[app_label] = None

21 views
Skip to first unread message

Django

unread,
Jan 25, 2016, 2:21:40 PM1/25/16
to django-...@googlegroups.com
#26135: The migrate command with `--run-syncdb` crash if an application's
migrations are disabled by setting MODULE_MIGRATIONS[app_label] = None
-------------------------------------------+------------------------
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.9
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
[https://github.com/django/django/pull/6029 PR]

Refs #24919.

--
Ticket URL: <https://code.djangoproject.com/ticket/26135>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 25, 2016, 4:04:50 PM1/25/16
to django-...@googlegroups.com
#26135: The migrate command with `--run-syncdb` crash if an application's
migrations are disabled by setting MODULE_MIGRATIONS[app_label] = None
-------------------------------------+-------------------------------------

Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.9
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/26135#comment:1>

Django

unread,
Jan 25, 2016, 10:01:45 PM1/25/16
to django-...@googlegroups.com
#26135: The migrate command with `--run-syncdb` crash if an application's
migrations are disabled by setting MODULE_MIGRATIONS[app_label] = None
-------------------------------------+-------------------------------------
Reporter: charettes | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 1.9
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette <charette.s@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"4dcaa5871b70859952c6f9c437dfe1b5f10509f2" 4dcaa587]:
{{{
#!CommitTicketReference repository=""
revision="4dcaa5871b70859952c6f9c437dfe1b5f10509f2"
Fixed #26135 -- Adjusted the migration questioner's handling of disabled
apps.

This was causing an issue when calling the `migrate` command in a test
case with
the `available_apps` attribute pointing to an application with migrations
disabled using the `MIGRATION_MODULES` setting.

Thanks to Tim Graham for the review.

Refs #24919
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26135#comment:2>

Django

unread,
Jan 25, 2016, 10:54:48 PM1/25/16
to django-...@googlegroups.com
#26135: The migrate command with `--run-syncdb` crash if an application's
migrations are disabled by setting MODULE_MIGRATIONS[app_label] = None
-------------------------------------+-------------------------------------
Reporter: charettes | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 1.9

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Simon Charette <charette.s@…>):

In [changeset:"abdbf00815ae8f49247082528d02a3d0890785a9" abdbf00]:
{{{
#!CommitTicketReference repository=""
revision="abdbf00815ae8f49247082528d02a3d0890785a9"
[1.9.x] Fixed #26135 -- Adjusted the migration questioner's handling of
disabled apps.

This was causing an issue when calling the `migrate` command in a test
case with
the `available_apps` attribute pointing to an application with migrations
disabled using the `MIGRATION_MODULES` setting.

Thanks to Tim Graham for the review.

Refs #24919

Backport of 4dcaa5871b70859952c6f9c437dfe1b5f10509f2 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26135#comment:3>

Reply all
Reply to author
Forward
0 new messages