[Django] #23092: Squasing migrations doesn't handles or warns about external dependencies

6 views
Skip to first unread message

Django

unread,
Jul 24, 2014, 8:03:29 AM7/24/14
to django-...@googlegroups.com
#23092: Squasing migrations doesn't handles or warns about external dependencies
-------------------------------+----------------------
Reporter: riklaunim | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.7-rc-1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------
Squashed migration won't keep external dependencies nor the command will
warn about manually re-adding them.

--
Ticket URL: <https://code.djangoproject.com/ticket/23092>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 24, 2014, 4:28:59 PM7/24/14
to django-...@googlegroups.com
#23092: Squasing migrations doesn't handles or warns about external dependencies
-------------------------------+--------------------------------------

Reporter: riklaunim | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.7-rc-1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by timo):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

Could you describe this more or add an example?

--
Ticket URL: <https://code.djangoproject.com/ticket/23092#comment:1>

Django

unread,
Jul 25, 2014, 3:21:06 AM7/25/14
to django-...@googlegroups.com
#23092: Squasing migrations doesn't handles or warns about external dependencies
-------------------------------+--------------------------------------

Reporter: riklaunim | Owner: nobody
Type: Uncategorized | Status: new
Component: Migrations | Version: 1.7-rc-1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by riklaunim):

When I have some dependencies in existing migrations like:
{{{
dependencies = [
migrations.swappable_dependency(settings.AUTH_USER_MODEL),
('some_app', 'some_migration'),
]
}}}

then in squashed migration dependencies list will be empty.

--
Ticket URL: <https://code.djangoproject.com/ticket/23092#comment:2>

Django

unread,
Jul 28, 2014, 3:15:40 PM7/28/14
to django-...@googlegroups.com
#23092: Squasing migrations doesn't handles or warns about external dependencies
---------------------------------+------------------------------------
Reporter: riklaunim | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.7-rc-2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timo):

* version: 1.7-rc-1 => 1.7-rc-2
* type: Uncategorized => Bug
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


Comment:

Thanks, I could reproduce this.

--
Ticket URL: <https://code.djangoproject.com/ticket/23092#comment:3>

Django

unread,
Jul 29, 2014, 1:22:58 PM7/29/14
to django-...@googlegroups.com
#23092: Squasing migrations doesn't handles or warns about external dependencies
---------------------------------+------------------------------------
Reporter: riklaunim | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 1.7-rc-2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Andrew Godwin <andrew@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"096a5de5d2bf564f859eca115874f5643ef31658"]:
{{{
#!CommitTicketReference repository=""
revision="096a5de5d2bf564f859eca115874f5643ef31658"
Fixed #23092: Squashing handles external dependencies
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23092#comment:4>

Django

unread,
Jul 29, 2014, 1:23:36 PM7/29/14
to django-...@googlegroups.com
#23092: Squasing migrations doesn't handles or warns about external dependencies
---------------------------------+------------------------------------
Reporter: riklaunim | Owner: nobody

Type: Bug | Status: closed
Component: Migrations | Version: 1.7-rc-2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------

Comment (by Andrew Godwin <andrew@…>):

In [changeset:"8e7fdfdb6fb0e910d5b507ba2da56a297bfba25c"]:
{{{
#!CommitTicketReference repository=""
revision="8e7fdfdb6fb0e910d5b507ba2da56a297bfba25c"
[1.7.x] Fixed #23092: Squashing handles external dependencies
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23092#comment:5>

Reply all
Reply to author
Forward
0 new messages