[Django] #23311: Windows/Python 3 test failure: test_comments_extractor
Django
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
{{{
======================================================================
FAIL: test_comments_extractor (i18n.test_extraction.BasicExtractorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "c:\Users\Tim\django\tests\i18n\test_extraction.py", line 151, in
test_comments_extractor
self.assertTrue('#. Translators: One-line translator comment #5 --
with non ASCII characters: áéíóúö' in po_contents)
AssertionError: False is not true
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23311>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Internationalization | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: makemessages | Needs documentation: 0
"Translators:" comments | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by ramiro):
* keywords: => makemessages "Translators:" comments
Comment:
This issue (i.e. the reported test failing on Windows+Python3):
- Is present in 1.5
- Was fixed for 1.6.x (bisection says by
b987fb188d3940830e323eed4ea6a121192011cd)
- Remains fixed in 1.7.x
- Is broken again in master (bisection says by
dbb48d2bb99a5f660cf2d85f137b8d87fc12d99f)
--
Ticket URL: <https://code.djangoproject.com/ticket/23311#comment:1>
Django
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Internationalization | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: makemessages | Needs documentation: 0
test-failure | UI/UX: 0
Has patch: 0 |
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* keywords: makemessages "Translators:" comments => makemessages
"Translators:" comments windows-test-failure
--
Ticket URL: <https://code.djangoproject.com/ticket/23311#comment:2>
Django
Reporter: timgraham | Owner: nobody
Type: Bug | Status: closed
Component: | Version: master
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: makemessages | Triage Stage: Accepted
"Translators:" comments windows- |
test-failure |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Ramiro Morales <ramiro@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"6fb9dee470d57882e378247fd2706d5f9867b5f9"]:
{{{
#!CommitTicketReference repository=""
revision="6fb9dee470d57882e378247fd2706d5f9867b5f9"
Fixed #23271 -- Don't corrupt PO files on Windows when updating them.
Make sure PO catalog text fetched from gettext programs via standard
output isn't corrupted by mismatch between assumed (UTF-8) and real
(CP1252) encodings. This can cause mojibake to be written when creating
or updating PO files.
Also fixes #23311.
Thanks to contributor with Trac nick 'danielmenzel' for the report,
excellent research and fix.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23311#comment:3>