[Django] #27299: Document Widget.use_required_attribute()

15 views
Skip to first unread message

Django

unread,
Sep 29, 2016, 7:31:55 PM9/29/16
to django-...@googlegroups.com
#27299: Document Widget.use_required_attribute()
------------------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The `Widget.use_required_attribute()` method added in
fab46ce6f5a0a58c4e5e39c9e5e412702beb4a64 seems to be a useful public API.
The following use case came up in #django-dev: "I am using a
[https://github.com/douglasmiranda/django-wysiwyg-
redactor/blob/master/redactor/widgets.py WYSIWYG] on the client side, it
is hiding a textarea which is required, chrome spits out a silient JS
error that a required field can not be "focused"."

--
Ticket URL: <https://code.djangoproject.com/ticket/27299>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 1, 2016, 8:55:52 AM10/1/16
to django-...@googlegroups.com
#27299: Document Widget.use_required_attribute()
--------------------------------------+------------------------------------

Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27299#comment:1>

Django

unread,
Oct 19, 2016, 9:25:45 AM10/19/16
to django-...@googlegroups.com
#27299: Document Widget.use_required_attribute()
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.10

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jon Dufresne):

* owner: nobody => Jon Dufresne
* status: new => assigned


Comment:

I will try to find some time for this.

--
Ticket URL: <https://code.djangoproject.com/ticket/27299#comment:2>

Django

unread,
Oct 22, 2016, 11:22:37 AM10/22/16
to django-...@googlegroups.com
#27299: Document Widget.use_required_attribute()
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.10

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jon Dufresne):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7419 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27299#comment:3>

Django

unread,
Oct 26, 2016, 8:41:46 AM10/26/16
to django-...@googlegroups.com
#27299: Document Widget.use_required_attribute()
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27299#comment:4>

Django

unread,
Oct 26, 2016, 10:29:42 PM10/26/16
to django-...@googlegroups.com
#27299: Document Widget.use_required_attribute()
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jon Dufresne <jon.dufresne@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"c74378bb77db5bbeac1bd48c0cd31154f96a81d6" c74378b]:
{{{
#!CommitTicketReference repository=""
revision="c74378bb77db5bbeac1bd48c0cd31154f96a81d6"
Fixed #27299 -- Documented the Widget.use_required_attribute() method.

Thanks Tim Graham for the review and edits.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27299#comment:5>

Django

unread,
Oct 26, 2016, 10:34:48 PM10/26/16
to django-...@googlegroups.com
#27299: Document Widget.use_required_attribute()
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jon Dufresne <jon.dufresne@…>):

In [changeset:"dda9a5928a565648ca604cde066c253db8871370" dda9a592]:
{{{
#!CommitTicketReference repository=""
revision="dda9a5928a565648ca604cde066c253db8871370"
[1.10.x] Fixed #27299 -- Documented the Widget.use_required_attribute()
method.

Thanks Tim Graham for the review and edits.

Backport of c74378b from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27299#comment:6>

Reply all
Reply to author
Forward
0 new messages