[Django] #27804: Use unittest.subTest() in Django's test suite
Django
------------------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
With Python 3.4+ support on master, Django's test suite may use
[https://docs.python.org/3/library/unittest.html#distinguishing-test-
iterations-using-subtests unittest.subTest] in loops. This makes debugging
test failures easier.
--
Ticket URL: <https://code.djangoproject.com/ticket/27804>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham):
I made an example change in the second commit of this
[https://github.com/django/django/pull/8008 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:1>
Django
Reporter: Tim Graham | Owner: Hitesh
Type: | Bhagchandani
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Hitesh Bhagchandani):
* owner: nobody => Hitesh Bhagchandani
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:2>
Django
Reporter: Tim Graham | Owner: Hitesh
Type: | Bhagchandani
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"f8d52521ab74e538f35c8dcf75760b5a2532c3b5" f8d52521]:
{{{
#!CommitTicketReference repository=""
revision="f8d52521ab74e538f35c8dcf75760b5a2532c3b5"
Refs #27804 -- Used subTest() in tests.utils_tests.test_html.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:3>
Django
Reporter: Tim Graham | Owner: Hitesh
Type: | Bhagchandani
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Bruno Alla):
Are you still working on this ticket Hitesh, or can I do some work on it?
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:4>
Django
Reporter: Tim Graham | Owner: Bruno
Type: | Alla
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bruno Alla):
* owner: Hitesh Bhagchandani => Bruno Alla
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:5>
Django
Reporter: Tim Graham | Owner: Bruno
Type: | Alla
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"6092ea8fa62191bf9ed8ebaae3125dcde9c4bbec" 6092ea8]:
{{{
#!CommitTicketReference repository=""
revision="6092ea8fa62191bf9ed8ebaae3125dcde9c4bbec"
Refs #27804 -- Used subTest() in several tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:6>
Django
Reporter: Tim Graham | Owner: Bruno
Type: | Alla
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"684c0a35f620a3754639b4cbadad16b7560b7c41" 684c0a35]:
{{{
#!CommitTicketReference repository=""
revision="684c0a35f620a3754639b4cbadad16b7560b7c41"
Refs #27804 -- Used subTest() in dateparse tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:7>
Django
Reporter: Tim Graham | Owner: Bruno
Type: | Alla
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"ceb5f1c9bf4befe1afadaf6906511fcea6b22b69" ceb5f1c9]:
{{{
#!CommitTicketReference repository=""
revision="ceb5f1c9bf4befe1afadaf6906511fcea6b22b69"
Refs #27804 -- Used subTest() in urlpatterns_reverse tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:8>
Django
Reporter: Tim Graham | Owner: Bruno
Type: | Alla
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"feb1a0a6922885eb0967428adf39fea9e4170ff8" feb1a0a]:
{{{
#!CommitTicketReference repository=""
revision="feb1a0a6922885eb0967428adf39fea9e4170ff8"
Refs #27804 -- Used subTest() in a syndication test.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:9>
Django
Reporter: Tim Graham | Owner: Bruno
Type: | Alla
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"dea4cfb95b6a32f584e1676725c835e3aea7d3c2" dea4cfb9]:
{{{
#!CommitTicketReference repository=""
revision="dea4cfb95b6a32f584e1676725c835e3aea7d3c2"
Refs #27804 -- Used subTest() in a modeladmin test.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:10>
Django
Reporter: Tim Graham | Owner: Bruno
Type: | Alla
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Marcin):
Hi guys :),
are you still working on this ticket? Can I continue?
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:11>
Django
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Bruno Alla):
* owner: Bruno Alla => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:12>
Django
Reporter: Tim Graham | Owner: (none)
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Bruno Alla):
Nope, go ahead!
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:13>
Django
Reporter: Tim Graham | Owner: Marcin
Type: | Baranowski
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Marcin Baranowski):
* owner: (none) => Marcin Baranowski
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:14>
Django
Reporter: Tim Graham | Owner: Marcin
Type: | Baranowski
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"f04e6732c33e0fd67e82ab2d59f230fa0045d15b" f04e6732]:
{{{
#!CommitTicketReference repository=""
revision="f04e6732c33e0fd67e82ab2d59f230fa0045d15b"
Refs #27804 -- Used subTest() in parse_accept_lang_header() test.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:15>
Django
Reporter: Tim Graham | Owner: Marcin
Type: | Baranowski
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Jezeniel Zapanta):
Is this still being worked on? I could continue this and for my first
contribution.
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:16>
Django
Reporter: Tim Graham | Owner: Marcin
Type: | Baranowski
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Marcin Baranowski):
Hi Jezeniel, I'm still working on this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:17>
Django
Reporter: Tim Graham | Owner: (none)
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Marcin Baranowski):
* owner: Marcin Baranowski => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:18>
Django
Reporter: Tim Graham | Owner: Ariel
Type: | Ferdman
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Ariel Ferdman):
* owner: (none) => Ariel Ferdman
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:19>
Django
Reporter: Tim Graham | Owner: (none)
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Ariel Ferdman):
* owner: Ariel Ferdman => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:20>
Django
Reporter: Tim Graham | Owner: (none)
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham):
* status: new => closed
* resolution: => fixed
Comment:
There may be some additional places to update but we can update them as
they are spotted rather than leaving this ticket open.
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:21>
Django
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"f5e7506cffc7f2c37718a0ca55de2dedbad3e23a" f5e7506]:
{{{
#!CommitTicketReference repository=""
revision="f5e7506cffc7f2c37718a0ca55de2dedbad3e23a"
Refs #27804 -- Used subTest in AdminViewPermissionsTest.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:22>
Django
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"10b0fd15763a8f4ac08633f7b4c091d6340faf3a" 10b0fd1]:
{{{
#!CommitTicketReference repository=""
revision="10b0fd15763a8f4ac08633f7b4c091d6340faf3a"
Refs #27804 -- Used subTest() in admin_scripts invalid name tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:23>
Django
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"de6d3afb97454e0653d55adadcf0df7e2a03c088" de6d3afb]:
{{{
#!CommitTicketReference repository=""
revision="de6d3afb97454e0653d55adadcf0df7e2a03c088"
Refs #27804 -- Used subTest() in HTMLEqualTests.test_self_closing_tags.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:24>
Django
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"498092377b3ad033b29a45ba5a05609682426f2d" 49809237]:
{{{
#!CommitTicketReference repository=""
revision="498092377b3ad033b29a45ba5a05609682426f2d"
Refs #27804 -- Used subTest() in BinaryFieldTests.test_set_and_retrieve.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:25>
Django
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: closed
Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"e065b293878b1e3ea56655aa9d33e87576cd77ff" e065b29]:
{{{
#!CommitTicketReference repository=""
revision="e065b293878b1e3ea56655aa9d33e87576cd77ff"
Refs #27804 -- Used subTest() in filesizeformat tests and HumanizeTests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:26>
Django
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: closed
Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"5dac63bb844d0a976e1dd1591a323c5ba9674a97" 5dac63b]:
{{{
#!CommitTicketReference repository=""
revision="5dac63bb844d0a976e1dd1591a323c5ba9674a97"
Refs #27804 -- Used subTest() in utils_tests/test_encoding.py.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:27>
Django
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: closed
Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by GitHub <noreply@…>):
In [changeset:"f47d5aac622c334ebeba06b7460204aeb98661e2" f47d5aa]:
{{{
#!CommitTicketReference repository=""
revision="f47d5aac622c334ebeba06b7460204aeb98661e2"
Refs #27804 -- Used subTest() in tests.utils_tests.test_text.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27804#comment:28>